Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide OpenAPI source action if it is not applicable #280

Closed
ericglau opened this issue Mar 30, 2020 · 1 comment · Fixed by #282
Closed

Hide OpenAPI source action if it is not applicable #280

ericglau opened this issue Mar 30, 2020 · 1 comment · Fixed by #282
Assignees
@bensonnw
Labels
bug Something isn't working
Milestone
v0.0.6

Comments

@ericglau
Copy link
Collaborator

Currently the source action to generate OpenAPI annotations will always appear even if it is not applicable. However, someone choosing this will see nothing happen, which is confusing. Instead, we should not display this option if it is not applicable.
@angelozerr
Copy link
Contributor

@bensonnw could you work on this issue?

@bensonnw bensonnw self-assigned this Mar 30, 2020
@angelozerr angelozerr mentioned this issue Mar 30, 2020
Merged
bensonnw pushed a commit to bensonnw/quarkus-ls that referenced this issue Mar 30, 2020
@benson-ning
Hide openapi code action if it is not applicable
a15cce6 
Fixes redhat-developer#280

signed-off-by: bensonn@ca.ibm.com
angelozerr pushed a commit that referenced this issue Mar 30, 2020
@benson-ning @angelozerr
Hide openapi code action if it is not applicable
eed5a4b 
Fixes #280

signed-off-by: bensonn@ca.ibm.com
@angelozerr angelozerr added this to the v0.0.6 milestone Mar 30, 2020
@xorye xorye added the bug Something isn't working label Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bensonnw bensonnw

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.0.6
Development

Successfully merging a pull request may close this issue.

Hide openapi code action if it is not applicable bensonnw/quarkus-ls
4 participants
@angelozerr @xorye @ericglau @bensonnw