Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing support for container-image properties #315

Closed
xorye opened this issue May 1, 2020 · 0 comments · Fixed by #344
Closed

Missing support for container-image properties #315

xorye opened this issue May 1, 2020 · 0 comments · Fixed by #344
Assignees
@angelozerr
Labels
bug Something isn't working
Milestone
v0.0.8

Comments

@xorye
Copy link

xorye commented May 1, 2020

As mentioned here #310 (comment), properties like:

quarkus.container-image.group
quarkus.container-image.registry
quarkus.container-image.username
quarkus.container-image.password

are not proposed until the quarkus-container-image-deployment.jar is added to the classpath.

Expected behavior:
Properties should be available when the quarkus-container-image-docker extension (and possibly quarkus-container-image-jib and quarkus-container-image-s2i extensions) are added to the project.
@angelozerr angelozerr mentioned this issue Jul 8, 2020
Closed
@angelozerr angelozerr added the bug Something isn't working label Jul 8, 2020
@jeffmaury jeffmaury mentioned this issue Jul 8, 2020
Closed
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Jul 8, 2020
Missing support for container-image properties
802ef09 
Fixes redhat-developer#315

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr self-assigned this Jul 8, 2020
@angelozerr angelozerr mentioned this issue Jul 8, 2020
Merged
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Jul 9, 2020
Missing support for container-image properties
ce14c55 
Fixes redhat-developer#315

Signed-off-by: azerr <azerr@redhat.com>
@fbricon fbricon added this to the v0.0.8 milestone Jul 9, 2020
@fbricon fbricon mentioned this issue Jul 9, 2020
Merged
fbricon pushed a commit that referenced this issue Jul 9, 2020
@fbricon
Missing support for container-image properties
50ec56e 
Fixes #315

Signed-off-by: azerr <azerr@redhat.com>
@jeffmaury jeffmaury mentioned this issue Jul 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.0.8
Development

Successfully merging a pull request may close this issue.

Missing support for container-image properties angelozerr/quarkus-ls
3 participants
@fbricon @angelozerr @xorye