Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel configuration used by Emitter not recognized as valid #369

Closed
fbricon opened this issue Nov 1, 2020 · 1 comment · Fixed by eclipse/lsp4mp#127
Closed

Channel configuration used by Emitter not recognized as valid #369

fbricon opened this issue Nov 1, 2020 · 1 comment · Fixed by eclipse/lsp4mp#127
Assignees
@datho7561
Labels
bug Something isn't working properties Features supported in application.properties validation
Milestone
v0.10.0

Comments

@fbricon
Copy link
Collaborator

fbricon commented Nov 1, 2020

I have a voting-booth Kafka channel that is written into via an Emitter:
https://github.com/fbricon/quarkus-spread-poll/blob/9974a7a872878d53d21d36fff95f996fe647faef/src/main/java/foo/bar/poller/PollResource.java#L25-L27

However, its configuration is shown as unknown in application.properties, as there's not @Outgoing annotation for that channel:
Screenshot 2020-11-01 at 18 26 26
@fbricon fbricon added bug Something isn't working properties Features supported in application.properties validation labels Nov 1, 2020
@angelozerr
Copy link
Contributor

At first I think this issue is for LSP4MP.

I don't know Emitter, if i understand correctly your issue, when Emiter annotation is used, it must generate incoming and outgoing properties?

@datho7561 datho7561 self-assigned this Nov 19, 2020
@angelozerr angelozerr added this to the v0.0.9 milestone Nov 20, 2020
datho7561 added a commit to datho7561/lsp4mp that referenced this issue Jan 26, 2021
@datho7561
Add properties for channel referenced by Emitter
97a7b7e 
Fixes redhat-developer/quarkus-ls#369

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 mentioned this issue Jan 27, 2021
Merged
datho7561 added a commit to datho7561/lsp4mp that referenced this issue Jan 27, 2021
@datho7561
Add properties for channel referenced by Emitter
0b83b7d 
Fixes redhat-developer/quarkus-ls#369

Signed-off-by: David Thompson <davthomp@redhat.com>
@angelozerr angelozerr modified the milestones: v0.0.9, v0.10.0 Mar 15, 2021
angelozerr pushed a commit to eclipse/lsp4mp that referenced this issue Mar 31, 2021
@datho7561 @angelozerr
Add properties for channel referenced by Emitter
b116fb5 
Fixes redhat-developer/quarkus-ls#369

Signed-off-by: David Thompson <davthomp@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@datho7561 datho7561

Labels
bug Something isn't working properties Features supported in application.properties validation
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging a pull request may close this issue.

Add properties for channel referenced by Emitter datho7561/lsp4mp
3 participants
@fbricon @angelozerr @datho7561