Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hover support for @Scheduled/cron #376

Closed
angelozerr opened this issue Dec 10, 2020 · 0 comments · Fixed by #379
Closed

Hover support for @Scheduled/cron #376

angelozerr opened this issue Dec 10, 2020 · 0 comments · Fixed by #379
Assignees
@rgrunber
Labels
enhancement New feature or request
Milestone
v0.10.0

Comments

@angelozerr
Copy link
Contributor

Do the same thing than ConfigProperty/name
@angelozerr angelozerr added the enhancement New feature or request label Dec 10, 2020
@angelozerr angelozerr added this to the v0.0.9 milestone Dec 10, 2020
rgrunber added a commit to rgrunber/lsp4mp that referenced this issue Dec 11, 2020
@rgrunber
Support arbitrary number of member values in PropertiesHoverParticipant.
ed7feda 
We should add support for any amount of member values for a given
annotation in addition to continued support for a single member value
and an optional default value member.

- Related redhat-developer/quarkus-ls#376

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber mentioned this issue Dec 11, 2020
Merged
rgrunber added a commit to rgrunber/lsp4mp that referenced this issue Jan 7, 2021
@rgrunber
Support arbitrary number of member values in PropertiesHoverParticipant.
804b5ce 
We should add support for any amount of member values for a given
annotation in addition to continued support for a single member value
and an optional default value member.

- Related redhat-developer/quarkus-ls#376

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/quarkus-ls that referenced this issue Jan 11, 2021
@rgrunber
Hover support for @scheduled annoation member values.
3277f3c 
- Fixes redhat-developer#376
- Add testcase

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber mentioned this issue Jan 11, 2021
Merged
rgrunber added a commit to rgrunber/quarkus-ls that referenced this issue Jan 14, 2021
@rgrunber
Hover support for @scheduled annoation member values.
1175d5e 
- Fixes redhat-developer#376
- Add testcase
- React to some class re-locations

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/lsp4mp that referenced this issue Jan 14, 2021
@rgrunber
Support arbitrary number of member values in PropertiesHoverParticipant.
c2d941b 
We should add support for any amount of member values for a given
annotation in addition to continued support for a single member value
and an optional default value member.

- Related redhat-developer/quarkus-ls#376

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/lsp4mp that referenced this issue Jan 15, 2021
@rgrunber
Support arbitrary number of member values in PropertiesHoverParticipant.
f314b4f 
We should add support for any amount of member values for a given
annotation in addition to continued support for a single member value
and an optional default value member.

- Related redhat-developer/quarkus-ls#376

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/quarkus-ls that referenced this issue Jan 15, 2021
@rgrunber
Hover support for @scheduled annoation member values.
db381a5 
- Fixes redhat-developer#376
- Add testcase
- React to some class re-locations

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/lsp4mp that referenced this issue Jan 15, 2021
@rgrunber
Support arbitrary number of member values in PropertiesHoverParticipant.
a12687e 
We should add support for any amount of member values for a given
annotation in addition to continued support for a single member value
and an optional default value member.

- Related redhat-developer/quarkus-ls#376
- Bump minimum required version of jdt.ls to 0.57.0.20200619102332

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
angelozerr pushed a commit to eclipse/lsp4mp that referenced this issue Jan 15, 2021
@rgrunber @angelozerr
Support arbitrary number of member values in PropertiesHoverParticipant.
5b6d0e3 
We should add support for any amount of member values for a given
annotation in addition to continued support for a single member value
and an optional default value member.

- Related redhat-developer/quarkus-ls#376
- Bump minimum required version of jdt.ls to 0.57.0.20200619102332

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/lsp4mp that referenced this issue Jan 19, 2021
@rgrunber
Improve range finding logic for annotation member values.
10b5c99 
- Related redhat-developer/quarkus-ls#376
- @foo (bar = {val}, baz = {val}) would fail when hovering over the
  2nd {val} because the index-of matching would detect the first
  {val}. Instead, we match against the target member (baz) and begin
  our index-of matching from the end of that term.

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/quarkus-ls that referenced this issue Jan 19, 2021
@rgrunber
Hover support for @scheduled annoation member values.
60d975e 
- Fixes redhat-developer#376
- Add testcase
- React to some class re-locations

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber mentioned this issue Jan 19, 2021
Merged
rgrunber added a commit to rgrunber/lsp4mp that referenced this issue Jan 20, 2021
@rgrunber
Improve range finding logic for annotation member values.
a181383 
- Related redhat-developer/quarkus-ls#376
- @foo (bar = "{val}", baz = "{val}") would fail when hovering over the
  2nd {val} because the index-of matching would detect the first
  {val}. Instead, we match against the target member (baz) and begin
  our index-of matching from the end of that term.

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/lsp4mp that referenced this issue Jan 20, 2021
@rgrunber
Improve range finding logic for annotation member values.
8d6ab4a 
- Related redhat-developer/quarkus-ls#376
- @foo (bar = "{val}", baz = "{val}") would fail when hovering over the
  2nd {val} because the index-of matching would detect the first
  {val}. Instead, we match against the target member (baz) and begin
  our index-of matching from the end of that term.

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
angelozerr pushed a commit to eclipse/lsp4mp that referenced this issue Jan 21, 2021
@rgrunber @angelozerr
Improve range finding logic for annotation member values.
bc926f7 
- Related redhat-developer/quarkus-ls#376
- @foo (bar = "{val}", baz = "{val}") would fail when hovering over the
  2nd {val} because the index-of matching would detect the first
  {val}. Instead, we match against the target member (baz) and begin
  our index-of matching from the end of that term.

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/quarkus-ls that referenced this issue Jan 21, 2021
@rgrunber
Hover support for @scheduled annoation member values.
9572cd2 
- Fixes redhat-developer#376
- Add testcase
- React to some class re-locations

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/quarkus-ls that referenced this issue Jan 21, 2021
@rgrunber
Hover support for @scheduled annoation member values.
7e792e4 
- Fixes redhat-developer#376
- Add testcase
- React to some class re-locations
- Bump target platform version of jdt.ls

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
angelozerr pushed a commit that referenced this issue Jan 22, 2021
@rgrunber @angelozerr
Hover support for @scheduled annoation member values.
1a5ec9b 
- Fixes #376
- Add testcase
- React to some class re-locations
- Bump target platform version of jdt.ls

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@datho7561 datho7561 modified the milestones: v0.0.9, v0.10.0 Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgrunber rgrunber

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging a pull request may close this issue.

Hover support for @Scheduled annoation member values. rgrunber/quarkus-ls
3 participants
@rgrunber @angelozerr @datho7561