Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore/include properties in application.properties depending on test scope #5

Closed
angelozerr opened this issue Aug 1, 2019 · 1 comment · Fixed by #95
Closed

Ignore/include properties in application.properties depending on test scope #5

angelozerr opened this issue Aug 1, 2019 · 1 comment · Fixed by #95
Assignees
Labels
bug Something isn't working properties Features supported in application.properties quarkus-jdt-extension
Milestone

Comments

@angelozerr
Copy link
Contributor

According @fbricon:

We need to consider the "test" flag of the source directory the application.properties is coming from.

  • if no "test" flag, then key/value pairs from test dependencies should not be considered to be returned to the client (edited)

  • if "test" flag is on, then key/value pairs from test dependencies should also be returned (edited)

As a use case, imagine an application.properties in src/test/resources, that would be able to use a specific test database (from a quarkus extension available in the test scope), in order to override a production DB defined in src/main/resources/application.properties

@angelozerr angelozerr added bug Something isn't working properties Features supported in application.properties quarkus-jdt-extension labels Aug 1, 2019
@fbricon fbricon changed the title Ignore application.properties from test folder Ignore/include properties in application.properties depending on test scope Aug 1, 2019
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 20, 2019
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 23, 2019
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 23, 2019
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 23, 2019
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 23, 2019
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 23, 2019
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 23, 2019
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 23, 2019
@angelozerr angelozerr self-assigned this Sep 25, 2019
@angelozerr angelozerr added this to the v0.2.0 milestone Sep 25, 2019
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 25, 2019
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 25, 2019
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 27, 2019
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 27, 2019
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 27, 2019
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 27, 2019
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 27, 2019
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 27, 2019
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 27, 2019
angelozerr pushed a commit that referenced this issue Sep 27, 2019
scope

Fixes #5

Signed-off-by: azerr <azerr@redhat.com>
@emmanuelbernard
Copy link

For info we have %test. prefix in the src/main/resource/application.properties file. I don't think we ever advertised the used of src/test/resource/application.properties.
It seems to work by accident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working properties Features supported in application.properties quarkus-jdt-extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants