Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indent snippet new line if LSP client doesn't support InsertTextMode#AdjustIndentation #727

Closed
angelozerr opened this issue Aug 30, 2022 · 0 comments · Fixed by #733
Closed

Indent snippet new line if LSP client doesn't support InsertTextMode#AdjustIndentation #727

angelozerr opened this issue Aug 30, 2022 · 0 comments · Fixed by #733
Assignees
@angelozerr
Labels
bug Something isn't working completion qute
Milestone
0.13.0

Comments

@angelozerr
Copy link
Contributor

In Eclipse IDE, the snippet section doesn't generate correctly the line identation (for new ines)

EclipseInlayHintDemo

After reading microsoft/language-server-protocol#83, I noticed that Eclipse IDE doesn't support InsertTextMode#AdjustIndentation, it means that we need to check this mode (coming from LSP client capability) and generate the proper line indentation in this case.
@angelozerr angelozerr added bug Something isn't working completion qute labels Aug 30, 2022
@angelozerr angelozerr self-assigned this Aug 31, 2022
@angelozerr angelozerr added this to the 0.13.0 milestone Aug 31, 2022
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 3, 2022
Indent snippet new line if LSP client doesn't support
ece5082 
InsertTextMode#AdjustIndentation

Fixes redhat-developer#727

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue Sep 3, 2022
Merged
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 3, 2022
Indent snippet new line if LSP client doesn't support
51564d8 
InsertTextMode#AdjustIndentation

Fixes redhat-developer#727

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 4, 2022
Indent snippet new line if LSP client doesn't support
796ae72 
InsertTextMode#AdjustIndentation

Fixes redhat-developer#727

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 5, 2022
Indent snippet new line if LSP client doesn't support
449c457 
InsertTextMode#AdjustIndentation

Fixes redhat-developer#727

Signed-off-by: azerr <azerr@redhat.com>
angelozerr pushed a commit to angelozerr/quarkus-ls that referenced this issue Sep 5, 2022
Indent snippet new line if LSP client doesn't support
bad7f3d 
InsertTextMode#AdjustIndentation

Fixes redhat-developer#727

Signed-off-by: azerr <azerr@redhat.com>
datho7561 pushed a commit that referenced this issue Sep 6, 2022
@datho7561
Indent snippet new line if LSP client doesn't support
285c224 
InsertTextMode#AdjustIndentation

Fixes #727

Signed-off-by: azerr <azerr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working completion qute
Projects
None yet
Milestone
0.13.0
1 participant
@angelozerr