Duplicate items when completing subclass of an object #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should work. I need to write tests and clean code. |
angelozerr
force-pushed
the
duplicate-methods
branch
4 times, most recently
from
16c73ef
to
9850caf
Compare
Fixes redhat-developer#460 Signed-off-by: azerr <azerr@redhat.com>
|
Test has been written. Now the Item extends BaseItem https://github.com/redhat-developer/quarkus-ls/pull/462/files#diff-5389f96df02523a1eda5128c477618aa9cbed351ee62b8b09aef78be075ea12fR63 . The QuteAssert completion checks for any test with completion that there is not duplicate label. |
|
Thanks @angelozerr ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate items when completing subclass of an object
Fixes #460
Signed-off-by: azerr azerr@redhat.com