Insert newly generated members at end #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
force-pushed
the
generate-member-at-end
branch
8 times, most recently
from
f7fa6f0
to
3f78ed6
Compare
datho7561
force-pushed
the
generate-member-at-end
branch
from
3f78ed6
to
a5c8cca
Compare
|
In addition the the feature improvements, I tried to clean up the code a bit. |
For the "generate missing member" qute-ls CodeAction, generate the missing member at the end of the respective list. i.e. place the new field at the end of the list of fields, or place the new getter method at the end of the list of methods. Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
generate-member-at-end
branch
from
a5c8cca
to
2bf1a0d
Compare
|
LGTM. Thanks @datho7561 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the "generate missing member" qute-ls CodeAction, generate the missing member at the end of the respective list. i.e. place the new field at the end of the list of fields, or place the new getter method at the end of the list of methods.
Signed-off-by: David Thompson davthomp@redhat.com