Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide basic support for #fragment section #768

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Provide basic support for #fragment section #768

merged 1 commit into from
Jan 17, 2023

Conversation

angelozerr
Copy link
Contributor

@angelozerr angelozerr commented Jan 16, 2023 •
edited

Provide basic support for #fragment section

image

This PR provides

  • #fragment snippet completion
  • avoid reporting undefined section tag for #fragment
  • improve completion and hover documentation fo all sections by adding links at the end of the documentation

See redhat-developer/vscode-quarkus#563

Signed-off-by: azerr azerr@redhat.com

@angelozerr angelozerr force-pushed the fragment-snippet branch 4 times, most recently from 9784c45 to f255c67 Compare January 16, 2023 14:51
@angelozerr angelozerr marked this pull request as ready for review January 16, 2023 15:16
@angelozerr angelozerr force-pushed the fragment-snippet branch 2 times, most recently from b88531c to ad73c67 Compare January 16, 2023 15:32
@angelozerr angelozerr mentioned this pull request Jan 16, 2023
Open
@angelozerr
Copy link
Contributor Author

@datho7561 I had had a strange problem. When I execute test on my local machine, I have some trouble (although CI build seems working?) I had to fix https://github.com/redhat-developer/quarkus-ls/pull/768/files#diff-0c6cba217b8d2aafec174ac4005b6f93e7e446f63641556079e995424cb62330

@angelozerr angelozerr changed the title Provide #fragment snippet Provide basic support for #fragment section Jan 16, 2023
@angelozerr
Copy link
Contributor Author

For fragment syntax coloration, see redhat-developer/vscode-quarkus#570

@datho7561
Copy link
Contributor

datho7561 commented Jan 16, 2023 •
edited

Locally, I have a compilation issue, but I think it's just that I installed a version of lsp4mp that hasn't been published

Update: yep, it's just because I had a branch checked out for lsp4mp

@angelozerr
Copy link
Contributor Author

Is this pr works for you @datho7561 ?

@datho7561
Copy link
Contributor

It seems to be working, although I need to test it more thoroughly and look over the code.

@angelozerr
Copy link
Contributor Author

I have the impression that CI build doesnt exe ute QuteHoverInUserTag?

@angelozerr
Copy link
Contributor Author

If you execute QuteHoverInUserTag.java in master you have 2 errors,No?

datho7561
datho7561 requested changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality seems to be working pretty good, although I found some things in the code.

qute.ls/com.redhat.qute.ls/src/main/java/com/redhat/qute/ls/commons/snippets/Link.java Outdated Show resolved Hide resolved
...m.redhat.qute.ls/src/main/java/com/redhat/qute/parser/template/sections/FragmentSection.java Show resolved Hide resolved
qute.ls/com.redhat.qute.ls/src/main/java/com/redhat/qute/utils/DocumentationUtils.java Show resolved Hide resolved
...ls/com.redhat.qute.ls/src/main/java/com/redhat/qute/ls/commons/snippets/SnippetRegistry.java Outdated Show resolved Hide resolved
@datho7561
Copy link
Contributor

Wait @angelozerr, do you have test failures with the code that is pushed? I don't have any.

@angelozerr
Copy link
Contributor Author

Wait @angelozerr, do you have test failures with the code that is pushed? I don't have any.

If I took master, tests fails and I fix with https://github.com/redhat-developer/quarkus-ls/pull/768/files#diff-0c6cba217b8d2aafec174ac4005b6f93e7e446f63641556079e995424cb62330 which is out of the scope of this PR.

@datho7561
Copy link
Contributor

If I check out master, the tests aren't failing for me locally. Given that the solution was updating a dependency, maybe it has something to do Maven repo configuration?

@angelozerr angelozerr force-pushed the fragment-snippet branch 2 times, most recently from 8a523f5 to 497bc71 Compare January 17, 2023 10:55
@angelozerr
Copy link
Contributor Author

If I check out master, the tests aren't failing for me locally. Given that the solution was updating a dependency, maybe it has something to do Maven repo configuration?

The 2 tests fails because those tests are wrong, the documentation should show Javadoc from field. In master the Javadoc is not included. It is my fix.

@datho7561 datho7561 added the enhancement New feature or request label Jan 17, 2023
@datho7561 datho7561 added this to the 0.14.0 milestone Jan 17, 2023
datho7561
datho7561 approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works well. Thanks, Angelo!

@datho7561 datho7561 merged commit 906a34f into redhat-developer:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request validation
Projects
IDE Raptors
Archived in project
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@angelozerr @datho7561