This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
Update to upstream 7.4.0 #1701
Closed
Update to upstream 7.4.0 #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@amisevsk PR check [build 1973] failed.Depending on failure reason, the artifacts or deployment may not be present. |
amisevsk
force-pushed
the
update-7.4.0
branch
from
f44d7bc
to
2f7ba75
Compare
@amisevsk RH-Che [build 1974] has been successfully deployed and tested.deployment: http://rhche-prcheck-1701.devtools-dev.ext.devshift.net |
davidfestal
approved these changes
Nov 18, 2019
ibuziuk
approved these changes
Nov 18, 2019
Closed
|
Removed WIP status, as I think 7.3.2 is stable on production. |
|
@amisevsk it looks like that 7.4.0 is affected by eclipse-che/che#15006 |
ibuziuk
force-pushed
the
update-7.4.0
branch
from
2f7ba75
to
ce135ab
Compare
@amisevsk PR check [build 1983] failed.Depending on failure reason, the artifacts or deployment may not be present. |
|
[test] |
@amisevsk PR check [build 1984] failed.Depending on failure reason, the artifacts or deployment may not be present. |
@amisevsk PR check [build 1986] failed.Depending on failure reason, the artifacts or deployment may not be present. |
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Pull upstream change 1c5c92147f - disable autosave on devfile editor Pull upstream change 2181ed1340 - fix dashboard build Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
Changes upstream mean that the create-workspace controller no longer hosts devfile selection. Changes required to apply ephemeral mode by default are instead moved to the ready-to-go-stacks controller. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Commit 51bb0bb13f in upstream causes builds to fail on any webpack error. To work around a typescript issue, commit 2181ed1340 adds 'index.d.ts' to the dashboard base directory. Since this is not included in the packaged maven artifact, this commit adds the same file to the rh-che dashboard directory and updates the build to copy it along with the rest of the sources. Should be undone when typescript is updated >3.5 Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Upstream commit 32515517bf removes che-ide-fetcher.service.ts and the cheBranding functions it depends on. This causes a webpack error on build and makes the dashboard unbuildable. Until a solution is found, this commit comments out che-ide-fetcher.service.ts Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Upstream commit 11bbcf0c10 reworks how filtering works in Che, removing AbstractKeycloakFilter. As the Fabric8WsMasterModule depends on this filter, and uses it to disable authentication on some paths, this needs to be removed from rh-che. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
force-pushed
the
update-7.4.0
branch
from
f8a5c1c
to
7b9cb76
Compare
|
I have added 5 commits to let us move to 7.5.1:
The changes I think are important to double check are:
|
|
Looks like there are some issues with commit 7b9cb76, as I'm seeing a "Authorization token is missing" error when trying to access the dashboard. |
@amisevsk PR check [build 1987] failed.Depending on failure reason, the artifacts or deployment may not be present. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update to upstream 7.4.0