This repository has been archived by the owner on Mar 17, 2021. It is now read-only.
CHE-283 : Add a property to disable keycloak authentication in rh-che assembly #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfestal
force-pushed
the
JBOSS-CHE-283
branch
from
7c236f9
to
37f1862
Compare
|
@davidfestal Does this PR also includes the work that is done in - #173 (there are common parts in both but some functionality is missing) ? |
No. I'm testing #173 currently (with a small modification to allow testing Keycloak on Minishift). Then when we merge #173 to But you have the opportunity to review the main changes of this PR in the meantime :-) |
|
@davidfestal ok, thanks for clarifications.
Could you please explain how to test #173 on Minishift ? |
davidfestal
added a commit
that referenced
this pull request
Jul 7, 2017
It's necessary to add it on `master` and on `openshift-connector-branch` to avoid a broken build when the related `fabric8-online` changes are be merged.
davidfestal
added a commit
that referenced
this pull request
Jul 7, 2017
It's necessary to add it on `master` and on `openshift-connector-branch` to avoid a broken build when the related `fabric8-online` changes are be merged.
davidfestal
added a commit
that referenced
this pull request
Jul 7, 2017
davidfestal
added a commit
that referenced
this pull request
Jul 7, 2017
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
force-pushed
the
JBOSS-CHE-283
branch
from
37f1862
to
748a479
Compare
mlabuda
added a commit
that referenced
this pull request
Jul 10, 2017
Signed-off-by: David Festal <dfestal@redhat.com>
This was referenced Jul 10, 2017
ibuziuk
approved these changes
Jul 10, 2017
sunix
pushed a commit
that referenced
this pull request
Jul 12, 2017
… assembly (#174) * First sketch of CHE-283 * Add the customized valve to enable bypassing Keycloak authentication * Disable Keycloak by default (as requested by @l0rd) in the RH assembly * Fix a bad bug bringing CORS errors due to duplicate headers in response * Clean formatting-only changes * Fix for #181 Signed-off-by: David Festal <dfestal@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the new
che.keycloak.disabledproperty in therh-che.propertiesfile.When this property is set to
true, all the related Keycloak actions, both client side and server-side are bypassed, and no authentication is required.