Make the Maven build compatible with M2Eclipse #87
Conversation
|
@mario could you review this PR please ? |
|
@davidfestal I think that we should review the list of strong requirements. I'm not sure we really need all of them. By the way I'm ok with this PR. Before merging I would like @ibuziuk and @sunix to have a look at that because I think they asked for this change. |
Sure, I should have said strong initial requirements. as soon as we are based on the upstream master and can have access to their snapshot Maven repository, point 3 and 4 wouldn't be strong constraints anymore. However requirements 1 or 2 are still relevant as far as I understand, and are really met by the current build structure. |
|
So finally I was able to also test this fix against the Che maven support (in OSIO): |
|
I've tested importing into eclipse, and it works great! Thanks @davidfestal |
| <groupId>com.google.inject</groupId> | ||
| <artifactId>guice</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>aopalliance</groupId> |
There was a problem hiding this comment.
Not sure this is related to the fix
There was a problem hiding this comment.
This is related to a pom sorting error I encountered during the work on this PR.
| @@ -10,7 +10,7 @@ | |||
| <parent> | |||
| <artifactId>che-parent</artifactId> | |||
| <groupId>org.eclipse.che</groupId> | |||
| <version>@che.version@</version> | |||
There was a problem hiding this comment.
because of that, I prefere this PR to be merged/adapted after #89
There was a problem hiding this comment.
Do you have any idea when you will be able to merge #89 ? it seems it depends on the merge of the openshift-connector-rebased branch of eclipse/che, which might take some more time.
What is the exact problem with this line ? Is it the fact that, on your openshift-connector-rebased branch, you will need to change the 5.6.0-openshift-connector-SNAPSHOT version to make it consistent with the upstream master version (which you already did for the root pom.xml here ?
There was a problem hiding this comment.
There was a problem hiding this comment.
< It would be useful for developers to have this PR merged while working on the remaining
+1, without David's fix it's utterly difficult to develop plugins for rh-che
| <configuration> | ||
| <sortProperties>false</sortProperties> | ||
| </configuration> | ||
| </plugin> |
There was a problem hiding this comment.
not sure this is related to the fix
Signed-off-by: David Festal <dfestal@redhat.com>
davidfestal
force-pushed
the
Make_Maven_Projects_Importable_In_Eclipse
branch
from
0098711
to
9572060
Compare
|
@sunix let me merge this in |
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
…eveloper#87) Signed-off-by: David Festal <dfestal@redhat.com>
…eveloper#87) Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Signed-off-by: David Festal <dfestal@redhat.com>
Description of the problem
The RH distribution build has several strong requirements such as:
assembly-ide-warGWT application) to provide the variants of the RH Che distribution artifacts,To meet these requirements, the maven build has a specific structure (using the maven
invokerplugin) that, until now, was not compatible with the M2Eclipse integration. This prevented using JDT services (completion, cross-references, etc ...) on modules that are also Java projects (such as the plugins or theassembly-wsmaster-war)Description of the Fix
This PR introduces slight changes that allow importing the RH distribution maven sub-modules as Maven projects in Eclipse. For projects that are Java projects, M2Eclipse can now correctly calculate the classpath based on the Maven POM file, and all the services of JDT are available again.
However the main structure of the build is not impacted, so that it doesn't impact / break the requirements described above.
Signed-off-by: David Festal dfestal@redhat.com