CHE-272: Moving setting GitHub access token functionality to rh-che #98
Conversation
ibuziuk
force-pushed
the
che-272
branch
2 times, most recently
from
ad467a3
to
1abbede
Compare
|
@l0rd @sunix after openshift-connector will be merged to master github force activation property should be moved from super() call in constructor - 1abbede#diff-1bf44ef91bbc868d5235bdea421f5341R40 Or we can update
Not sure if it really worth doing it now though |
|
I have slept on it and decided that it is important to remove setting github access token functionality from openshift-connector branch now to make transition to master smooth. It will be required to update che-starter with support of two versions of setting access token API (old & new one) |
|
PR has been updated
|
| @@ -2,3 +2,6 @@ | |||
| # Endpoints for obtiaining Github / OpenShift Online tokens based on Keycloak token | |||
| che.keycloak.oso.endpoint=NULL | |||
| che.keycloak.github.endpoint=NULL | |||
|
|
|||
| # Register GitHub access token without client id and secret | |||
| oauth.github.forceactivation=false | |||
There was a problem hiding this comment.
maybe should be true by default in our case (rh-che)? so we don't need to customize it in our template
| !isNullOrEmpty(tokenUri) && | ||
| redirectUris != null && redirectUris.length != 0) { | ||
|
|
||
| configure("NULL", "NULL", redirectUris, authUri, tokenUri, new MemoryDataStoreFactory()); |
There was a problem hiding this comment.
maybe we could just remove this "forceActivation" as in rh-che it would be always activated
There was a problem hiding this comment.
yup, technically we can and probably should do this
|
PR has been updated |
|
|
||
| @Inject | ||
| public OpenShiftGitHubOAuthAuthenticator(@Nullable @Named("che.oauth.github.clientid") String clientId, | ||
| @Nullable @Named("che.oauth.github.clientsecret") String clientSecret, |
There was a problem hiding this comment.
clientId and clientSecret are not used anymore right ? and can be removed
Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
|
@sunix PR has been updated |
…Hub access token functionality Details in redhat-developer/rh-che#98
No description provided.