Release sbo 1.2.0 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kartikey Mamgain <mamgainkartikey@gmail.com>
| name: service-binding-operator | ||
| type: application | ||
| urls: | ||
| - service-binding-operator-1.1.0.tgz |
There was a problem hiding this comment.
I think it is good, but just for me to understand, what is the criteria to move this version to patch , minor or major
There was a problem hiding this comment.
I think since we have changed the template/test and added a param to values.yaml this should be a minor changes , so 1.1.0. Previously there was no major change on the chart, only the image hash in the deployment image changed.
When sbo moves to 2.x.x. we should move as well considering that will be a major change.
Going forward for the sake of consistency i would say we should keep the app version and chart version same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates service binding operator repository with app version 1.2.0
Signed-off-by: Kartikey Mamgain mamgainkartikey@gmail.com