Skip to content
This repository has been archived by the owner on Jun 26, 2024. It is now read-only.

binding:env:attribute being missed/ignored currently while fetching info from x-descriptors #656

Closed
Avni-Sharma opened this issue Aug 31, 2020 · 1 comment
Closed

binding:env:attribute being missed/ignored currently while fetching info from x-descriptors #656

Avni-Sharma opened this issue Aug 31, 2020 · 1 comment
Labels
kind/bug Something isn't working v0.4

Comments

@Avni-Sharma
Copy link
Contributor

If we try to export the backing service values via just the x-descriptors(i.e CSV in OLM) then binding:env:attribute or binding:volumemount:attribute is missed currently here https://github.com/redhat-developer/service-binding-operator/blob/master/pkg/controller/servicebindingrequest/service.go#L82 . Need to tackle it as https://gist.githubusercontent.com/isutton/61e20b4034207ef065821246df6ab3a4/raw/2764b977396f4ac9148b7dd4ea5b2e234bddbbe4/loadDescriptor.go as suggested by @isutton .
@Avni-Sharma Avni-Sharma added the kind/bug Something isn't working label Aug 31, 2020
@pratikjagrut pratikjagrut mentioned this issue Sep 7, 2020
Merged
@sbose78 sbose78 added the v0.4 label Oct 1, 2020
@pedjak
Copy link
Contributor

pedjak commented Oct 6, 2020

Got obsolete after merging #403

@pedjak pedjak closed this as completed Oct 6, 2020
@pmacik pmacik mentioned this issue Nov 4, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug Something isn't working v0.4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pedjak @sbose78 @Avni-Sharma