Detect bindable kinds and expose them for client discovery #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedjak
changed the title
|
/retest |
|
@pedjak The acceptance test |
pmacik
requested changes
Sep 29, 2021
pedjak
force-pushed
the
bindable-kinds
branch
from
caf22d9
to
551c619
Compare
pedjak
force-pushed
the
bindable-kinds
branch
2 times, most recently
from
8bcfbd0
to
b96767d
Compare
The operator detects `CustomResourceDefinitions` exposing binding data and reports bindable resource types (group, version, kind) within cluster-scoped instance of `BindableKinds`, under `.status` field: ``` apiVersion: binding.operators.coreos.com/v1alpha1 kind: BindableKinds metadata: name: bindable-kinds status: - group: stable.example.com kind: BindableBackend version: v1 . . . ``` There is only one instance of `BindableKinds`, named `bindable-kinds` Signed-off-by: Predrag Knezevic <pknezevi@redhat.com>
pedjak
force-pushed
the
bindable-kinds
branch
from
b96767d
to
fb0d66d
Compare
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmacik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator detects
CustomResourceDefinitionsexposing binding dataand reports bindable resource types (group, version, kind) within
cluster-scoped instance of
BindableKinds, under.statusfield:There is only one instance of
BindableKinds, namedbindable-kinds