Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organize Makefile into smaller managable pieces #1148

Merged

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented May 19, 2022

Signed-off-by: Pavel Macík pavel.macik@gmail.com

Changes

Currently, there is only one big Makefile with everyghing in which makes it difficult to read, navigate and manage.

Splitting it into smaller managable pieces remove those pitfalls.

Additionally, having parts of Makefile organized in smaller pieces by a topic such as build or docs makes it possible to skip acceptance testing PR checks in cases of PRs that do not affect images that are build from sources and tested by the acceptance tests (for example PRs that only touches documentation).

In such cases there is not much value running the full acceptance testing arsenal that takes hours to complete and tests something that is already tested. Not running acceptance tests for PR such as documentation related ones significantly reduces time for those PRs to get merged as well as the cost spent for OpenShift CI jobs that provisions (currently 4) OCP clusters on AWS for each PR check run.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik pmacik added the kind/enhancement New feature or request label May 19, 2022
@openshift-ci openshift-ci bot requested review from baijum and sadlerap May 19, 2022 08:04
@pmacik
Copy link
Contributor Author

pmacik commented May 19, 2022

/test performance

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #1148 (c796147) into master (c796147) will not change coverage.
The diff coverage is n/a.

❗ Current head c796147 differs from pull request most recent head c77b88d. Consider uploading reports for the commit c77b88d to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1148   +/-   ##
=======================================
  Coverage   57.84%   57.84%           
=======================================
  Files          31       31           
  Lines        2697     2697           
=======================================
  Hits         1560     1560           
  Misses        976      976           
  Partials      161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c796147...c77b88d. Read the comment docs.

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
@pmacik
Copy link
Contributor Author

pmacik commented May 19, 2022

/test performance

@pmacik
Copy link
Contributor Author

pmacik commented May 19, 2022

/retest

@dperaza4dustbit
Copy link
Contributor

/lgtm

Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sadlerap
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 763dca0 into redhat-developer:master May 23, 2022
@pmacik pmacik deleted the makefile-reorg branch August 12, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants