-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-organize Makefile into smaller managable pieces #1148
Re-organize Makefile into smaller managable pieces #1148
Conversation
/test performance |
Codecov Report
@@ Coverage Diff @@
## master #1148 +/- ##
=======================================
Coverage 57.84% 57.84%
=======================================
Files 31 31
Lines 2697 2697
=======================================
Hits 1560 1560
Misses 976 976
Partials 161 161 Continue to review full report at Codecov.
|
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
/test performance |
/retest |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadlerap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Pavel Macík pavel.macik@gmail.com
Changes
Currently, there is only one big
Makefile
with everyghing in which makes it difficult to read, navigate and manage.Splitting it into smaller managable pieces remove those pitfalls.
Additionally, having parts of
Makefile
organized in smaller pieces by a topic such asbuild
ordocs
makes it possible to skip acceptance testing PR checks in cases of PRs that do not affect images that are build from sources and tested by the acceptance tests (for example PRs that only touches documentation).In such cases there is not much value running the full acceptance testing arsenal that takes hours to complete and tests something that is already tested. Not running acceptance tests for PR such as documentation related ones significantly reduces time for those PRs to get merged as well as the cost spent for OpenShift CI jobs that provisions (currently 4) OCP clusters on AWS for each PR check run.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedback
tag.