Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not skip acceptance tests if the main Dockerfile is changed. #1168

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Jun 13, 2022

Signed-off-by: Pavel Macík pavel.macik@gmail.com

Changes

Currently the skip detector misses the main Dockerfile as in case of #1166. This PR:

  • Includes the main Dockerfile
  • Changes the filter to match files exactly (instead of using .startsWith method as for directories)

The skipping filter for acceptance tests with OpenShift (CI) is covered by openshift/release#29427

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik pmacik added kind/bug Something isn't working ci CI related issues labels Jun 13, 2022
@openshift-ci openshift-ci bot requested review from baijum and shruthihub June 13, 2022 21:08
@github-actions github-actions bot added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Jun 13, 2022
@pmacik
Copy link
Contributor Author

pmacik commented Jun 13, 2022

/hold

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #1168 (527e9ad) into master (130d04a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1168   +/-   ##
=======================================
  Coverage   58.08%   58.08%           
=======================================
  Files          33       33           
  Lines        2839     2839           
=======================================
  Hits         1649     1649           
  Misses       1029     1029           
  Partials      161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 130d04a...527e9ad. Read the comment docs.

@pmacik
Copy link
Contributor Author

pmacik commented Jun 13, 2022

/unhold

@baijum
Copy link
Member

baijum commented Jun 23, 2022

/lgtm

@baijum
Copy link
Member

baijum commented Jun 23, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baijum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmacik
Copy link
Contributor Author

pmacik commented Jun 23, 2022

/retest

5 similar comments
@pmacik
Copy link
Contributor Author

pmacik commented Jun 23, 2022

/retest

@pmacik
Copy link
Contributor Author

pmacik commented Jun 23, 2022

/retest

@pmacik
Copy link
Contributor Author

pmacik commented Jun 23, 2022

/retest

@pmacik
Copy link
Contributor Author

pmacik commented Jun 24, 2022

/retest

@pmacik
Copy link
Contributor Author

pmacik commented Jul 18, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2022

@pmacik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.11-acceptance 3e497dc link true /test 4.11-acceptance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
@pmacik pmacik force-pushed the fix/check-skip-acceptance-tests branch from 3e497dc to 527e9ad Compare July 18, 2022 11:28
@openshift-ci openshift-ci bot removed the lgtm label Jul 18, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2022

New changes are detected. LGTM label has been removed.

@pmacik
Copy link
Contributor Author

pmacik commented Jul 18, 2022

Rebased to latest master for the acceptance tests for the latest feature (#1161)

@pmacik pmacik added the lgtm label Jul 27, 2022
@openshift-merge-robot openshift-merge-robot merged commit c40394f into redhat-developer:master Jul 27, 2022
@pmacik pmacik deleted the fix/check-skip-acceptance-tests branch August 12, 2022 15:02
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 24, 2022
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 25, 2022
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance-tests-skipped Marks PR that does not need to run the acceptance tests approved ci CI related issues kind/bug Something isn't working lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants