Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH action for security scan. #1171

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Jun 16, 2022

Signed-off-by: Pavel Macík pavel.macik@gmail.com

Ref: https://issues.redhat.com/browse/APPSVC-1136

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik pmacik added the ci CI related issues label Jun 16, 2022
@github-actions github-actions bot added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Jun 16, 2022
@pmacik pmacik changed the title Add GH action for security scan. [WIP] Add GH action for security scan. Jun 16, 2022
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #1171 (fe62499) into master (73f3873) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1171   +/-   ##
=======================================
  Coverage   58.71%   58.71%           
=======================================
  Files          33       33           
  Lines        2781     2781           
=======================================
  Hits         1633     1633           
  Misses        987      987           
  Partials      161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73f3873...fe62499. Read the comment docs.

@github-actions github-actions bot removed the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Jun 16, 2022
@pmacik pmacik force-pushed the trivy-action branch 6 times, most recently from 3706ce5 to e931773 Compare June 16, 2022 17:09
@pmacik
Copy link
Contributor Author

pmacik commented Jun 16, 2022

/retest

Copy link
Contributor

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

echo "::set-output name=operator-image-ref::${OPERATOR_IMAGE_REF}"

- name: Run Trivy vulnerability scanner in IaC mode
uses: aquasecurity/trivy-action@master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
@pmacik pmacik changed the title [WIP] Add GH action for security scan. Add GH action for security scan. Jun 16, 2022
@pmacik
Copy link
Contributor Author

pmacik commented Jun 17, 2022

/retest

@pmacik pmacik added this to the 1.1.1 milestone Jun 17, 2022
@baijum
Copy link
Member

baijum commented Jun 17, 2022

/lgtm

@pmacik
Copy link
Contributor Author

pmacik commented Jun 17, 2022

/test 4.11-acceptance

@pmacik pmacik mentioned this pull request Jun 17, 2022
4 tasks
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 771154a into redhat-developer:master Jun 17, 2022
@pmacik pmacik deleted the trivy-action branch August 12, 2022 15:01
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 25, 2022
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci CI related issues lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants