Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore security warnings without known fixes #1178

Merged
merged 1 commit into from Jun 24, 2022

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Jun 23, 2022

Signed-off-by: Pavel Macík pavel.macik@gmail.com

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
@openshift-ci openshift-ci bot requested review from baijum and sadlerap June 23, 2022 12:46
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #1178 (73d101b) into master (e618586) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1178   +/-   ##
=======================================
  Coverage   58.69%   58.69%           
=======================================
  Files          33       33           
  Lines        2782     2782           
=======================================
  Hits         1633     1633           
  Misses        988      988           
  Partials      161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e618586...73d101b. Read the comment docs.

Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 23, 2022
@pmacik pmacik changed the title Ignore security warnings that have no known fixes. Ignore security warnings without known fixes Jun 23, 2022
@baijum
Copy link
Member

baijum commented Jun 24, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baijum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 7dd72db into redhat-developer:master Jun 24, 2022
@pmacik pmacik deleted the trivy-ignore-unfixed branch August 12, 2022 15:01
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 24, 2022
…1178)

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 25, 2022
…1178)

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 26, 2022
…1178)

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants