Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample apps #1181

Merged

Conversation

yselkowitz
Copy link
Contributor

Changes

Updates the sample apps to the latest upstreams. Please make push-app-multiarch in each directory to propogate new builds.

/kind documentation

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
@openshift-ci openshift-ci bot added the kind/documentation Improvements or additions to documentation label Jul 6, 2022
@github-actions github-actions bot added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Jul 6, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2022

Hi @yselkowitz. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #1181 (8f484b1) into master (3afddcc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1181   +/-   ##
=======================================
  Coverage   58.69%   58.69%           
=======================================
  Files          33       33           
  Lines        2782     2782           
=======================================
  Hits         1633     1633           
  Misses        988      988           
  Partials      161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3afddcc...8f484b1. Read the comment docs.

@baijum
Copy link
Member

baijum commented Jul 18, 2022

/ok-to-test

@yselkowitz
Copy link
Contributor Author

/assign @jasperchui

@baijum
Copy link
Member

baijum commented Jul 25, 2022

/retest

@pmacik
Copy link
Contributor

pmacik commented Jul 25, 2022

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 765fd2b into redhat-developer:master Jul 25, 2022
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Aug 24, 2022
Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Aug 25, 2022
Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Aug 26, 2022
Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance-tests-skipped Marks PR that does not need to run the acceptance tests approved kind/documentation Improvements or additions to documentation lgtm ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants