Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add negative scenario for Provisioned Service referencing non-existing secret #1188

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Jul 26, 2022

Signed-off-by: Pavel Macík pavel.macik@gmail.com

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik pmacik requested review from sadlerap and removed request for shruthihub July 26, 2022 13:54
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sadlerap
Copy link
Contributor

/retest

…g secret.

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
@pmacik pmacik force-pushed the provisioned-service-negative branch from c3cc4c3 to fae0483 Compare July 26, 2022 16:21
@openshift-ci openshift-ci bot removed the lgtm label Jul 26, 2022
@pmacik
Copy link
Contributor Author

pmacik commented Jul 26, 2022

Rebased for #1186
/cc @sadlerap

@openshift-ci openshift-ci bot requested a review from sadlerap July 26, 2022 16:23
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jul 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadlerap
Copy link
Contributor

@pmacik Looks like Acceptance tests w/ OLM are failing; it's the same test that's failing for #1176 🤔.

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #1188 (fae0483) into master (0da92c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1188   +/-   ##
=======================================
  Coverage   58.08%   58.08%           
=======================================
  Files          33       33           
  Lines        2839     2839           
=======================================
  Hits         1649     1649           
  Misses       1029     1029           
  Partials      161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0da92c0...fae0483. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit 65729eb into redhat-developer:master Jul 26, 2022
pmacik added a commit that referenced this pull request Jul 27, 2022
…g secret. (#1188)

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
@pmacik pmacik deleted the provisioned-service-negative branch August 12, 2022 15:01
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 24, 2022
…g secret. (redhat-developer#1188)

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 25, 2022
…g secret. (redhat-developer#1188)

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 26, 2022
…g secret. (redhat-developer#1188)

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants