Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): collect kube resources and split acceptance testing jobs #1189

Merged

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Jul 27, 2022

Signed-off-by: Pavel Macík pavel.macik@gmail.com

Currently, when acceptance tests fail, the kube resources are not collected and archived by GH actions for debug purposes.

Additionally, one of the acceptance tests started to fail recently in the Kubernetes with OLM job due to too many pods being created in the minikube. That prevented creation of the pods for the test which caused the test to fail.

Changes

This PR:

  • Enables collecting and archiving kube resources for GH actions for situations when acceptance tests failed.
  • Moves Workload Resource Mapping PR Check acceptance tests to the separate job.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik pmacik added kind/bug Something isn't working ci CI related issues labels Jul 27, 2022
@pmacik pmacik changed the title Collect and archive kube resources even when tests failed fix(ci): collect and archive kube resources even when tests failed Jul 27, 2022
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #1189 (7943cea) into master (c40394f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1189   +/-   ##
=======================================
  Coverage   58.08%   58.08%           
=======================================
  Files          33       33           
  Lines        2839     2839           
=======================================
  Hits         1649     1649           
  Misses       1029     1029           
  Partials      161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c40394f...7943cea. Read the comment docs.

@baijum
Copy link
Member

baijum commented Jul 27, 2022

/lgtm

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
@pmacik pmacik changed the title fix(ci): collect and archive kube resources even when tests failed fix(ci): collect kube resources and split acceptance testing jobs Jul 27, 2022
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 27, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5e3e546 into redhat-developer:master Jul 27, 2022
@pmacik pmacik deleted the fix/gha-artifacts branch August 12, 2022 15:00
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 24, 2022
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 25, 2022
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci CI related issues kind/bug Something isn't working lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants