Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document rebind behavior #1197

Merged
merged 1 commit into from Aug 23, 2022
Merged

Document rebind behavior #1197

merged 1 commit into from Aug 23, 2022

Conversation

baijum
Copy link
Member

@baijum baijum commented Aug 9, 2022

Fixes #1187

Signed-off-by: Baiju Muthukadan baiju.m.mail@gmail.com

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from baijum by writing /assign @baijum in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baijum baijum requested review from dperaza4dustbit and removed request for shruthihub August 9, 2022 09:16
@github-actions github-actions bot added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Aug 9, 2022
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #1197 (73c0ff4) into master (c233e02) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1197   +/-   ##
=======================================
  Coverage   57.96%   57.96%           
=======================================
  Files          33       33           
  Lines        2838     2838           
=======================================
  Hits         1645     1645           
  Misses       1032     1032           
  Partials      161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c233e02...73c0ff4. Read the comment docs.

Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baijum PTAL at the suggestions. Thanks!

Fixes redhat-developer#1187

Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
@baijum baijum requested a review from pmacik August 19, 2022 04:39
@baijum baijum merged commit 8622634 into redhat-developer:master Aug 23, 2022
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Aug 25, 2022
Fixes redhat-developer#1187

Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Aug 26, 2022
Fixes redhat-developer#1187

Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Aug 26, 2022
Fixes redhat-developer#1187

Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
@baijum baijum deleted the rebind branch November 11, 2022 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance-tests-skipped Marks PR that does not need to run the acceptance tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

service-binding-operator does not rebind a deleted and recreated deployment
2 participants