Use fewer pod replicas in testing deployments #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need the resiliancy of 3 replicas for generic-test-app deployments during acceptance tests. Explicitly set `replicas: 1` in our deployments to reduce pod utilization. Signed-off-by: Andy Sadler <ansadler@redhat.com>
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baijum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Codecov Report
@@ Coverage Diff @@
## master #1207 +/- ##
=======================================
Coverage 57.96% 57.96%
=======================================
Files 33 33
Lines 2838 2838
=======================================
Hits 1645 1645
Misses 1032 1032
Partials 161 161 Continue to review full report at Codecov.
|
pmacik
pushed a commit
to pmacik/service-binding-operator
that referenced
this pull request
Aug 25, 2022
We don't need the resiliancy of 3 replicas for generic-test-app deployments during acceptance tests. Explicitly set `replicas: 1` in our deployments to reduce pod utilization. Signed-off-by: Andy Sadler <ansadler@redhat.com> Signed-off-by: Andy Sadler <ansadler@redhat.com>
pmacik
pushed a commit
to pmacik/service-binding-operator
that referenced
this pull request
Aug 26, 2022
We don't need the resiliancy of 3 replicas for generic-test-app deployments during acceptance tests. Explicitly set `replicas: 1` in our deployments to reduce pod utilization. Signed-off-by: Andy Sadler <ansadler@redhat.com> Signed-off-by: Andy Sadler <ansadler@redhat.com>
pmacik
pushed a commit
to pmacik/service-binding-operator
that referenced
this pull request
Aug 26, 2022
We don't need the resiliancy of 3 replicas for generic-test-app deployments during acceptance tests. Explicitly set `replicas: 1` in our deployments to reduce pod utilization. Signed-off-by: Andy Sadler <ansadler@redhat.com> Signed-off-by: Andy Sadler <ansadler@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We don't need the resiliancy of 3 replicas for generic-test-app deployments during acceptance tests. Explicitly set
replicas: 1in our deployments to reduce pod utilization.Signed-off-by: Andy Sadler ansadler@redhat.com
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedbacktag.