Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hack script for creating release branches from master #1211

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Sep 1, 2022

Changes

This PR adds a hack script that automates creation of a release branch based on master by performing the following steps:

  • Create a release branch in SBO repository
  • Add a label to the SBO repository to be used to mark PRs to be cherry-picked in the release branch
  • Prepare a PR branch for openshift/release repository adding OpenShift CI jobs for running acceptance and performance tests on PRs to the release branch

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@github-actions github-actions bot added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Sep 1, 2022
@pmacik pmacik changed the title Add hack script for creating release branch from master Add hack script for creating release branches from master Sep 1, 2022
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #1211 (fff99f9) into master (f718d53) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1211   +/-   ##
=======================================
  Coverage   58.16%   58.16%           
=======================================
  Files          35       35           
  Lines        3007     3007           
=======================================
  Hits         1749     1749           
  Misses       1090     1090           
  Partials      168      168           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f718d53...fff99f9. Read the comment docs.

@pmacik pmacik marked this pull request as draft September 1, 2022 13:08
@pmacik pmacik force-pushed the branch-release-hack-script branch 2 times, most recently from 0847967 to f6f45e0 Compare September 2, 2022 08:01
@github-actions github-actions bot removed the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Sep 2, 2022
@sadlerap sadlerap mentioned this pull request Sep 2, 2022
@pmacik pmacik force-pushed the branch-release-hack-script branch 7 times, most recently from eb87415 to 9f08b33 Compare September 6, 2022 10:04
@pmacik
Copy link
Contributor Author

pmacik commented Sep 6, 2022

/test all

@pmacik pmacik marked this pull request as ready for review September 7, 2022 07:57
@openshift-ci openshift-ci bot requested a review from baijum September 7, 2022 07:57
@baijum
Copy link
Member

baijum commented Sep 20, 2022

/lgtm

Copy link
Member

@baijum baijum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 14, 2022
@baijum baijum requested review from baijum and removed request for shruthihub November 14, 2022 12:29
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
@pmacik
Copy link
Contributor Author

pmacik commented Nov 16, 2022

/retest

Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b50fe9e into redhat-developer:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants