Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update operator manifests with spec v1beta1 resources #1215

Merged

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Sep 5, 2022

Followup to #1176

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik pmacik added the release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch label Sep 5, 2022
@pmacik pmacik changed the title Update operator manifests with spec v1beta1 Update operator manifests with spec v1beta1 resources Sep 5, 2022
@pmacik pmacik added this to the 1.2.0 milestone Sep 5, 2022
@pmacik
Copy link
Contributor Author

pmacik commented Sep 5, 2022

/retest

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #1215 (be2677b) into master (c13bba5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1215   +/-   ##
=======================================
  Coverage   58.05%   58.05%           
=======================================
  Files          33       33           
  Lines        2844     2844           
=======================================
  Hits         1651     1651           
  Misses       1032     1032           
  Partials      161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13bba5...be2677b. Read the comment docs.

Copy link
Member

@baijum baijum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baijum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 6, 2022
@openshift-merge-robot openshift-merge-robot merged commit 8563a7c into redhat-developer:master Sep 6, 2022
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants