Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test upgrade SBO with OLM #1221

Merged

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Sep 7, 2022

Changes

This PR:

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 7, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #1221 (012a5b4) into master (29f6e70) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1221   +/-   ##
=======================================
  Coverage   58.23%   58.23%           
=======================================
  Files          35       35           
  Lines        2988     2988           
=======================================
  Hits         1740     1740           
  Misses       1082     1082           
  Partials      166      166           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29f6e70...012a5b4. Read the comment docs.

@pmacik pmacik force-pushed the sbo-upgrade-test branch 8 times, most recently from 6528b4f to 3b28446 Compare September 7, 2022 13:43
@pmacik
Copy link
Contributor Author

pmacik commented Sep 7, 2022

/test all

@pmacik pmacik force-pushed the sbo-upgrade-test branch 18 times, most recently from eca766c to 1c8cb9b Compare September 11, 2022 19:07
@pmacik pmacik force-pushed the sbo-upgrade-test branch 2 times, most recently from 537f061 to 9b009dc Compare November 3, 2022 11:27
@pmacik pmacik changed the title WIP: SBO upgrade test Test upgrade SBO with OLM Nov 3, 2022
@pmacik pmacik marked this pull request as ready for review November 3, 2022 11:27
@pmacik
Copy link
Contributor Author

pmacik commented Nov 3, 2022

/hold

@pmacik
Copy link
Contributor Author

pmacik commented Nov 3, 2022

/retest

@pmacik
Copy link
Contributor Author

pmacik commented Nov 3, 2022

/unhold

@pmacik
Copy link
Contributor Author

pmacik commented Nov 4, 2022

/retest

1 similar comment
@pmacik
Copy link
Contributor Author

pmacik commented Nov 7, 2022

/retest

@pmacik pmacik force-pushed the sbo-upgrade-test branch 2 times, most recently from 9f091a6 to a4c19bd Compare November 7, 2022 13:59
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@baijum baijum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baijum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 584b425 into redhat-developer:master Nov 14, 2022
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Jan 11, 2023
pmacik added a commit that referenced this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants