Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update chart directory with service binding operator 1.2.0 #1222

Merged
merged 1 commit into from Sep 19, 2022
Merged

Update chart directory with service binding operator 1.2.0 #1222

merged 1 commit into from Sep 19, 2022

Conversation

Kartikey-star
Copy link
Contributor

Signed-off-by: Kartikey Mamgain mamgainkartikey@gmail.com

This PR updates the chart directory with service binding operator 1.2.0 source chart.

@github-actions github-actions bot added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022 •
edited

Codecov Report

Merging #1222 (415b017) into master (f98979a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1222   +/-   ##
=======================================
  Coverage   58.05%   58.05%           
=======================================
  Files          33       33           
  Lines        2844     2844           
=======================================
  Hits         1651     1651           
  Misses       1032     1032           
  Partials      161      161

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f98979a...415b017. Read the comment docs.

@Kartikey-star Kartikey-star marked this pull request as draft September 8, 2022 12:45
@Kartikey-star Kartikey-star marked this pull request as ready for review September 8, 2022 13:40
dperaza4dustbit
dperaza4dustbit approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kartikey-star
Copy link
Contributor Author

Kartikey-star commented Sep 9, 2022 •
edited

@dperaza4dustbit needed to change the test file because we need to set securitycontext.runAsNonRoot to true for openshift and false for vanilla clusters. In order to do so the test pod,value.yaml and Readme has been updated. Hence i made the chart version as 1.1.0.

@Kartikey-star
Copy link
Contributor Author

Chart tested on aws eks and openshift cluster.

@Kartikey-star Kartikey-star force-pushed the release_chart_1.2.0 branch 9 times, most recently from 2d9cdba to 5690409 Compare September 12, 2022 07:43
@Kartikey-star
Copy link
Contributor Author

Chart tested on aws eks and openshift cluster with latest changes

@Kartikey-star
SBO 1.2.0 helm chart
415b017 
Signed-off-by: Kartikey Mamgain <mamgainkartikey@gmail.com>
@pmacik
Copy link
Contributor

pmacik commented Sep 19, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Sep 19, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmacik pmacik added the release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch label Sep 19, 2022
@openshift-merge-robot openshift-merge-robot merged commit d7d21eb into redhat-developer:master Sep 19, 2022
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Sep 19, 2022
@Kartikey-star @pmacik
SBO 1.2.0 helm chart (redhat-developer#1222)
e413b14 
Signed-off-by: Kartikey Mamgain <mamgainkartikey@gmail.com>
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Sep 20, 2022
@Kartikey-star @pmacik
SBO 1.2.0 helm chart (redhat-developer#1222)
8ce2d37 
Signed-off-by: Kartikey Mamgain <mamgainkartikey@gmail.com>
pmacik added a commit that referenced this pull request Sep 22, 2022
@pmacik
SBO 1.2.0 helm chart (#1222) (#1226)
6ae44d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmacik pmacik pmacik left review comments

@sadlerap sadlerap Awaiting requested review from sadlerap

@shruthihub shruthihub Awaiting requested review from shruthihub

@dperaza4dustbit dperaza4dustbit Awaiting requested review from dperaza4dustbit

Assignees

@pmacik pmacik

Labels
acceptance-tests-skipped Marks PR that does not need to run the acceptance tests approved lgtm release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Kartikey-star @pmacik @dperaza4dustbit @sadlerap @openshift-merge-robot