Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RHOAS operator installation and CSV headers for performance test #1233

Merged

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Sep 26, 2022

Signed-off-by: Pavel Macík pavel.macik@gmail.com

The upstream version of RHOAS operator uses sqlite type of index image (quay.io/rhoas/service-operator-registry:autolatest) which is no longer supported or available in OCP 4.12.

Changes

This PR:

  • Changes the source of RHOAS installation for the performance test to be the in-cluster community-operators catalog.
  • Fixes output CSV headers

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik pmacik added release/v1.1.x Used to mark PRs to be cherry-picked in release-v1.1.x branch release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch labels Sep 26, 2022
@github-actions github-actions bot added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Sep 26, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #1233 (6b81a7b) into master (923685a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1233   +/-   ##
=======================================
  Coverage   58.05%   58.05%           
=======================================
  Files          33       33           
  Lines        2844     2844           
=======================================
  Hits         1651     1651           
  Misses       1032     1032           
  Partials      161      161           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 923685a...6b81a7b. Read the comment docs.

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
@pmacik pmacik changed the title Fix RHOAS operator installation for performance test on OCP 4.12 Fix RHOAS operator installation and CSV headers for performance test Sep 29, 2022
Copy link
Contributor

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dperaza4dustbit
Copy link
Contributor

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dperaza4dustbit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a0f4e76 into redhat-developer:master Sep 29, 2022
pmacik added a commit that referenced this pull request Oct 4, 2022
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Oct 4, 2022
…hat-developer#1233)

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance-tests-skipped Marks PR that does not need to run the acceptance tests approved lgtm release/v1.1.x Used to mark PRs to be cherry-picked in release-v1.1.x branch release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants