Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or temporarily disable tests for supported operators that does not currently work with OCP 4.12 #1262

Merged
merged 1 commit into from Oct 11, 2022

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Oct 10, 2022

Signed-off-by: Pavel Macík pavel.macik@gmail.com

Currently:

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik pmacik added release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch labels Oct 10, 2022
@pmacik pmacik force-pushed the fix-crunchy branch 2 times, most recently from 28d876d to d34d43d Compare October 11, 2022 05:18
@pmacik pmacik changed the title Upgrade Crunchy operator to v5.2.0 Upgrade Crunchy operator to v5.2.0 and temporarily disable for OCP 4.12 Oct 11, 2022
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
@pmacik pmacik changed the title Upgrade Crunchy operator to v5.2.0 and temporarily disable for OCP 4.12 Fix or temporarily disable supported operator tests for OCP 4.12 Oct 11, 2022
@pmacik pmacik changed the title Fix or temporarily disable supported operator tests for OCP 4.12 Fix or temporarily disable supported operator tests that does not currently work with OCP 4.12 Oct 11, 2022
@pmacik pmacik changed the title Fix or temporarily disable supported operator tests that does not currently work with OCP 4.12 Fix and temporarily disable supported operator tests that does not currently work with OCP 4.12 Oct 11, 2022
@pmacik pmacik changed the title Fix and temporarily disable supported operator tests that does not currently work with OCP 4.12 Fix or temporarily disable supported operator tests that does not currently work with OCP 4.12 Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #1262 (5db3a3a) into master (0535239) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1262   +/-   ##
=======================================
  Coverage   58.06%   58.06%           
=======================================
  Files          33       33           
  Lines        2797     2797           
=======================================
  Hits         1624     1624           
  Misses       1018     1018           
  Partials      155      155           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0535239...5db3a3a. Read the comment docs.

@pmacik pmacik changed the title Fix or temporarily disable supported operator tests that does not currently work with OCP 4.12 Fix or temporarily disable tests for supported operators that does not currently work with OCP 4.12 Oct 11, 2022
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
I'd really like to re-enable these tests for 4.12 at some point, but that can be done separately; this is blocking us from the 1.3 release.

@pmacik
Copy link
Contributor Author

pmacik commented Oct 11, 2022

I'd really like to re-enable these tests for 4.12 at some point, but that can be done separately; this is blocking us from the 1.3 release.

Yes, the point is to re-enable those scenarios as soon as the related operators work with 4.12

Copy link
Contributor

@dperaza4dustbit dperaza4dustbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dperaza4dustbit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1e5b9c7 into redhat-developer:master Oct 11, 2022
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Oct 11, 2022
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
pmacik added a commit to pmacik/service-binding-operator that referenced this pull request Oct 11, 2022
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
openshift-merge-robot pushed a commit that referenced this pull request Oct 11, 2022
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
openshift-merge-robot pushed a commit that referenced this pull request Oct 11, 2022
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants