-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix or temporarily disable tests for supported operators that does not currently work with OCP 4.12 #1262
Fix or temporarily disable tests for supported operators that does not currently work with OCP 4.12 #1262
Conversation
28d876d
to
d34d43d
Compare
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1262 +/- ##
=======================================
Coverage 58.06% 58.06%
=======================================
Files 33 33
Lines 2797 2797
=======================================
Hits 1624 1624
Misses 1018 1018
Partials 155 155 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I'd really like to re-enable these tests for 4.12 at some point, but that can be done separately; this is blocking us from the 1.3 release.
Yes, the point is to re-enable those scenarios as soon as the related operators work with 4.12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dperaza4dustbit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Pavel Macík <pavel.macik@gmail.com> Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Signed-off-by: Pavel Macík <pavel.macik@gmail.com> Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Signed-off-by: Pavel Macík pavel.macik@gmail.com
Currently:
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedback
tag.