-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare various KPIs to the threshold values and fail if any is crossed #1271
Compare various KPIs to the threshold values and fail if any is crossed #1271
Conversation
Skipping CI for Draft Pull Request. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1271 +/- ##
=======================================
Coverage 58.06% 58.06%
=======================================
Files 33 33
Lines 2797 2797
=======================================
Hits 1624 1624
Misses 1018 1018
Partials 155 155 Continue to review full report at Codecov.
|
/test 4.10-performance-reduced |
1 similar comment
/test 4.10-performance-reduced |
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
42a7ae1
to
e7dfbdd
Compare
/test 4.10-performance-reduced |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
…ded (redhat-developer#1271) Signed-off-by: Pavel Macík <pavel.macik@gmail.com> Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Signed-off-by: Pavel Macík pavel.macik@gmail.com
Changes
This PR:
test-performance-thresholds
Makefile targed that compares various vaules fromkpi.yaml
generated bymake test-performance-collect-kpi
to the threshold values defined in environment variablesTEST_PERFORMANCE_AVG_MEMORY
,TEST_PERFORMANCE_MAX_MEMORY
,TEST_PERFORMANCE_AVG_CPU
,TEST_PERFORMANCE_MAX_CPU
. If any of the threshold is crossed it fails.test-performance-thresholds
is to be executed as part ofperformance*
OpenShift CI jobs ([rhd-sbo] Add periodic (weekly) jobs to run performance tests openshift/release#33192) (after thetest-performance-collect-kpi
step) and fails the job if any of the thresholds is crossed.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedback
tag.