Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Percona MongoDB operator support #1284

Merged
merged 1 commit into from Oct 25, 2022
Merged

Fix Percona MongoDB operator support #1284

merged 1 commit into from Oct 25, 2022

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Oct 22, 2022

Signed-off-by: Pavel Macík pavel.macik@gmail.com

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik pmacik added the release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch label Oct 22, 2022
@pmacik pmacik added the release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch label Oct 22, 2022
@pmacik
Copy link
Contributor Author

pmacik commented Oct 22, 2022

/retest

1 similar comment
@pmacik
Copy link
Contributor Author

pmacik commented Oct 23, 2022

/retest

@pmacik
Copy link
Contributor Author

pmacik commented Oct 24, 2022

The actual acceptance tests for 4.9 are passing, but there is a timeout issue in OpenShift CI - the gather-must-gather step recently started to take more than 10minutes which causes it to timeout (the default). I've sent a PR to the OpenShift CI repo (openshift/release#33361) to increase that timeout to 30 minutes for 4.9 tests

@pmacik
Fix Percona MongoDB operator support
11e49b8 
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
@pmacik
Copy link
Contributor Author

pmacik commented Oct 24, 2022

rebased

sadlerap
sadlerap approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Does this need to be backported for 1.3.1?

@openshift-ci openshift-ci bot added the lgtm label Oct 24, 2022
@sadlerap
Copy link
Contributor

/retest

1 similar comment
@pmacik
Copy link
Contributor Author

pmacik commented Oct 24, 2022

/retest

@pmacik
Copy link
Contributor Author

pmacik commented Oct 24, 2022 •
edited

/lgtm
Does this need to be backported for 1.3.1?

Well, technically this PR adds support for binding v1 resources for the Percona Mongo DB CRs, while the older apis are deprecated by Percona, so I guess we should.

@sadlerap
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 24, 2022 •
edited

Codecov Report

Merging #1284 (11e49b8) into master (6eb10a5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1284   +/-   ##
=======================================
  Coverage   58.06%   58.06%           
=======================================
  Files          33       33           
  Lines        2797     2797           
=======================================
  Hits         1624     1624           
  Misses       1018     1018           
  Partials      155      155

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eb10a5...11e49b8. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit 1a1a1fe into redhat-developer:master Oct 25, 2022
service-binding-operator-bot pushed a commit to service-binding-operator-bot/service-binding-operator that referenced this pull request Oct 25, 2022
@pmacik @web-flow
Fix Percona MongoDB operator support (redhat-developer#1284)
26734b3 
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
service-binding-operator-bot pushed a commit to service-binding-operator-bot/service-binding-operator that referenced this pull request Oct 25, 2022
@pmacik @web-flow
Fix Percona MongoDB operator support (redhat-developer#1284)
536134b 
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
@pmacik pmacik removed the release/v1.2.x Used to mark PRs to be cherry-picked in release-v1.2.x branch label Oct 25, 2022
openshift-merge-robot pushed a commit that referenced this pull request Oct 25, 2022
@service-binding-operator-bot @pmacik
Fix Percona MongoDB operator support (#1284) (#1290)
c908e8b 
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Co-authored-by: Pavel Macík <pavel.macik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadlerap sadlerap sadlerap approved these changes

@baijum baijum Awaiting requested review from baijum

@dperaza4dustbit dperaza4dustbit Awaiting requested review from dperaza4dustbit

Assignees

@sadlerap sadlerap

Labels
approved lgtm release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmacik @sadlerap @openshift-merge-robot