Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource samples in CSV #1294

Merged

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Oct 31, 2022

Signed-off-by: Pavel Macík pavel.macik@gmail.com

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@pmacik pmacik added the release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch label Oct 31, 2022
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #1294 (f32dc65) into master (120dad9) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1294   +/-   ##
=======================================
  Coverage   58.06%   58.06%           
=======================================
  Files          33       33           
  Lines        2797     2797           
=======================================
  Hits         1624     1624           
  Misses       1018     1018           
  Partials      155      155           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 120dad9...f32dc65. Read the comment docs.

Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one change, lgtm.

Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sadlerap
Copy link
Contributor

sadlerap commented Nov 3, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 3, 2022
@openshift-merge-robot openshift-merge-robot merged commit 4810c32 into redhat-developer:master Nov 4, 2022
service-binding-operator-bot pushed a commit to service-binding-operator-bot/service-binding-operator that referenced this pull request Nov 4, 2022
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
openshift-merge-robot pushed a commit that referenced this pull request Nov 7, 2022
Signed-off-by: Pavel Macík <pavel.macik@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Co-authored-by: Pavel Macík <pavel.macik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants