-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump version to v1.3.2 for helm chart #1321
bump version to v1.3.2 for helm chart #1321
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1321 +/- ##
=======================================
Coverage 58.16% 58.16%
=======================================
Files 35 35
Lines 3007 3007
=======================================
Hits 1749 1749
Misses 1090 1090
Partials 168 168 Continue to review full report at Codecov.
|
/lgtm |
/hold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sadlerap The operator image also needs to be changed in the chart at https://github.com/redhat-developer/service-binding-operator/blob/master/charts/service-binding-operator/templates/deployment.yaml#L32 to match the released one:
diff --git a/charts/service-binding-operator/templates/deployment.yaml b/charts/service-binding-operator/templates/deployment.yaml
index 0bd95408..06eb20f8 100644
--- a/charts/service-binding-operator/templates/deployment.yaml
+++ b/charts/service-binding-operator/templates/deployment.yaml
@@ -29,7 +29,7 @@ spec:
- --zap-log-level=info
command:
- /manager
- image: {{.Values.image.image | default (printf "%s/%s" .Values.image.repository "servicebinding-operator@sha256:67c2a2502f59fac1e7ded9ed19b59bbd4e50f5559a13978a87ecd2283b81e067") | quote}}
+ image: {{.Values.image.image | default (printf "%s/%s" .Values.image.repository "servicebinding-operator@sha256:30bf7f0f21024bb2e1e4db901b1f5e89ab56e0f3197a919d2bbb670f3fe5223a") | quote}}
imagePullPolicy: {{.Values.image.pullPolicy}}
securityContext:
allowPrivilegeEscalation: false
@sadlerap The Additionally, you PR only changes the chart which does not fall under any of the following list:
Anything related to the chart or the chart itself is not covered in acceptance tests, at all. So the execution of the acceptance tests was skipped (and marked as such) correctly. |
Signed-off-by: Andy Sadler <ansadler@redhat.com>
dd1123a
to
d3734af
Compare
hmm, not sure why it says I unset |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmacik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Andy Sadler <ansadler@redhat.com> Signed-off-by: Andy Sadler <ansadler@redhat.com>
Signed-off-by: Andy Sadler ansadler@redhat.com
Changes
Bumps the version in our help chart manifest to v1.3.2.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedback
tag.