Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version to v1.3.2 for helm chart #1321

Conversation

sadlerap
Copy link
Contributor

Signed-off-by: Andy Sadler ansadler@redhat.com

Changes

Bumps the version in our help chart manifest to v1.3.2.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@github-actions github-actions bot added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Dec 14, 2022
@sadlerap sadlerap added release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch and removed acceptance-tests-skipped Marks PR that does not need to run the acceptance tests labels Dec 14, 2022
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #1321 (d3734af) into master (5204c03) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1321   +/-   ##
=======================================
  Coverage   58.16%   58.16%           
=======================================
  Files          35       35           
  Lines        3007     3007           
=======================================
  Hits         1749     1749           
  Misses       1090     1090           
  Partials      168      168           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5204c03...d3734af. Read the comment docs.

@baijum
Copy link
Member

baijum commented Dec 15, 2022

/lgtm

@pmacik
Copy link
Contributor

pmacik commented Dec 15, 2022

/hold

Copy link
Contributor

@pmacik pmacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadlerap The operator image also needs to be changed in the chart at https://github.com/redhat-developer/service-binding-operator/blob/master/charts/service-binding-operator/templates/deployment.yaml#L32 to match the released one:

diff --git a/charts/service-binding-operator/templates/deployment.yaml b/charts/service-binding-operator/templates/deployment.yaml
index 0bd95408..06eb20f8 100644
--- a/charts/service-binding-operator/templates/deployment.yaml
+++ b/charts/service-binding-operator/templates/deployment.yaml
@@ -29,7 +29,7 @@ spec:
         - --zap-log-level=info
         command:
         - /manager
-        image: {{.Values.image.image | default (printf "%s/%s" .Values.image.repository "servicebinding-operator@sha256:67c2a2502f59fac1e7ded9ed19b59bbd4e50f5559a13978a87ecd2283b81e067") | quote}}
+        image: {{.Values.image.image | default (printf "%s/%s" .Values.image.repository "servicebinding-operator@sha256:30bf7f0f21024bb2e1e4db901b1f5e89ab56e0f3197a919d2bbb670f3fe5223a") | quote}}
         imagePullPolicy: {{.Values.image.pullPolicy}}
         securityContext:
           allowPrivilegeEscalation: false 

@pmacik pmacik added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Dec 15, 2022
@pmacik
Copy link
Contributor

pmacik commented Dec 15, 2022

@sadlerap The acceptance-tests-skipped label is only an indicator whether the acceptance tests were skipped or not by the CI, the acceptance tests won't execute if you unset-it.

Additionally, you PR only changes the chart which does not fall under any of the following list:

  • SBO release
  • images or operator manifests
  • the acceptance testing framework
  • the related CI

Anything related to the chart or the chart itself is not covered in acceptance tests, at all. So the execution of the acceptance tests was skipped (and marked as such) correctly.

Signed-off-by: Andy Sadler <ansadler@redhat.com>
@sadlerap
Copy link
Contributor Author

hmm, not sure why it says I unset acceptance-tests-skipped; I certainly didn't intend to do that.

@openshift-ci openshift-ci bot removed the lgtm label Dec 15, 2022
@pmacik
Copy link
Contributor

pmacik commented Dec 15, 2022

/unhold

Copy link
Contributor

@pmacik pmacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit bcd1e4a into redhat-developer:master Dec 15, 2022
service-binding-operator-bot pushed a commit to service-binding-operator-bot/service-binding-operator that referenced this pull request Dec 15, 2022
Signed-off-by: Andy Sadler <ansadler@redhat.com>

Signed-off-by: Andy Sadler <ansadler@redhat.com>
openshift-merge-robot pushed a commit that referenced this pull request Dec 15, 2022
Signed-off-by: Andy Sadler <ansadler@redhat.com>

Signed-off-by: Andy Sadler <ansadler@redhat.com>

Signed-off-by: Andy Sadler <ansadler@redhat.com>
Co-authored-by: Andy Sadler <ansadler@redhat.com>
@sadlerap sadlerap deleted the release-v1.3.2/helm-chart branch December 15, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance-tests-skipped Marks PR that does not need to run the acceptance tests approved lgtm release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants