Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support to upload performance kpi data to opensearch #1331

Merged

Conversation

tisutisu
Copy link
Contributor

Changes

Adding support for uploading performance kpi metrics to the opensearch instance as part of the story: https://issues.redhat.com/browse/APPSVC-1261

/kind enhancement

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@openshift-ci openshift-ci bot added the kind/enhancement New feature or request label Dec 21, 2022
@openshift-ci openshift-ci bot requested review from baijum and pmacik December 21, 2022 10:14
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 21, 2022

Hi @tisutisu. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label Dec 21, 2022
@pmacik pmacik self-assigned this Dec 21, 2022
make/performance.mk Outdated Show resolved Hide resolved
test/performance/upload_data.py Outdated Show resolved Hide resolved
@pmacik
Copy link
Contributor

pmacik commented Dec 21, 2022

/ok-to-test

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #1331 (e7eb106) into master (b09c381) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1331   +/-   ##
=======================================
  Coverage   58.16%   58.16%           
=======================================
  Files          35       35           
  Lines        3007     3007           
=======================================
  Hits         1749     1749           
  Misses       1090     1090           
  Partials      168      168           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b09c381...e7eb106. Read the comment docs.

@sadlerap
Copy link
Contributor

@tisutisu #1332 landed, please rebase.

Addressed review comments

Signed-off-by: Sushanta Das <sushanta.das.ju@gmail.com>
Copy link
Contributor

@pmacik pmacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pmacik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 49afef3 into redhat-developer:master Dec 23, 2022
pmacik pushed a commit to pmacik/service-binding-operator that referenced this pull request Jan 19, 2023
…eveloper#1363

* Adding support to upload performance kpi data to opensearch (redhat-developer#1331)
* Fixed the environment issue in CI (redhat-developer#1335)
* Added metadata with performance kpi data upload (redhat-developer#1363)

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
@pmacik pmacik added the release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch label Jan 19, 2023
openshift-merge-robot pushed a commit that referenced this pull request Jan 19, 2023
* Adding support to upload performance kpi data to opensearch (#1331)
* Fixed the environment issue in CI (#1335)
* Added metadata with performance kpi data upload (#1363)

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>

Signed-off-by: Pavel Macík <pavel.macik@gmail.com>
Co-authored-by: Sushanta Das <sushanta.das.ju@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance-tests-skipped Marks PR that does not need to run the acceptance tests approved kind/enhancement New feature or request lgtm ok-to-test release/v1.3.x Used to mark PRs to be cherry-picked in release-v1.3.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants