-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reconciler for spec v1alpha3 version #1334
Remove reconciler for spec v1alpha3 version #1334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it also safe to no longer register v1alpha3 resources with our known schemes? If so, we can also probably remove line 64 in main.go (and the import as well).
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1334 +/- ##
=======================================
Coverage 58.16% 58.16%
=======================================
Files 35 35
Lines 3007 3007
=======================================
Hits 1749 1749
Misses 1090 1090
Partials 168 168 Continue to review full report at Codecov.
|
Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
5c73f0d
to
1d3595d
Compare
I think it's okay to remove that registration. I have updated the PR with some other cleanup also. Please check again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sadlerap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Baiju Muthukadan baiju.m.mail@gmail.com
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedback
tag.