Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reconciler for spec v1alpha3 version #1334

Merged

Conversation

baijum
Copy link
Member

@baijum baijum commented Dec 22, 2022

Signed-off-by: Baiju Muthukadan baiju.m.mail@gmail.com

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it also safe to no longer register v1alpha3 resources with our known schemes? If so, we can also probably remove line 64 in main.go (and the import as well).

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Merging #1334 (1d3595d) into master (7136c43) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1334   +/-   ##
=======================================
  Coverage   58.16%   58.16%           
=======================================
  Files          35       35           
  Lines        3007     3007           
=======================================
  Hits         1749     1749           
  Misses       1090     1090           
  Partials      168      168           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7136c43...1d3595d. Read the comment docs.

Signed-off-by: Baiju Muthukadan <baiju.m.mail@gmail.com>
@baijum
Copy link
Member Author

baijum commented Dec 22, 2022

Is it also safe to no longer register v1alpha3 resources with our known schemes? If so, we can also probably remove line 64 in main.go (and the import as well).

I think it's okay to remove that registration. I have updated the PR with some other cleanup also. Please check again.

Copy link
Contributor

@sadlerap sadlerap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadlerap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b09c381 into redhat-developer:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants