Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove @pmacik as owner #1433

Merged
merged 1 commit into from May 2, 2023

Conversation

sadlerap
Copy link
Contributor

@sadlerap sadlerap commented May 2, 2023

Changes

Removes @pmacik as an owner.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

Signed-off-by: Andy Sadler <ansadler@redhat.com>
@github-actions github-actions bot added the acceptance-tests-skipped Marks PR that does not need to run the acceptance tests label May 2, 2023
@filariow
Copy link
Contributor

filariow commented May 2, 2023

/lgtm

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #1433 (e5a11f0) into master (acaf059) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1433   +/-   ##
=======================================
  Coverage   58.21%   58.21%           
=======================================
  Files          35       35           
  Lines        3011     3011           
=======================================
  Hits         1753     1753           
  Misses       1090     1090           
  Partials      168      168           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acaf059...e5a11f0. Read the comment docs.

@sadlerap
Copy link
Contributor Author

sadlerap commented May 2, 2023

/test 4.10-acceptance
/test 4.11-acceptance
/test 4.12-acceptance

@sadlerap
Copy link
Contributor Author

sadlerap commented May 2, 2023

@filariow I also need a /approve for this to get merged

@filariow
Copy link
Contributor

filariow commented May 2, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filariow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label May 2, 2023
@openshift-merge-robot openshift-merge-robot merged commit 0dded83 into redhat-developer:master May 2, 2023
22 checks passed
@sadlerap sadlerap deleted the owners branch May 3, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance-tests-skipped Marks PR that does not need to run the acceptance tests approved lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants