Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(release-v1.4.x): ci: run security checks on push to branch #1487

Conversation

service-binding-operator-bot
Copy link
Collaborator

Changes

Recently in PRs, we've been getting warnings that our SAST tools don't have a known configuration for some branches. To fix this warning, we need to add push hooks for master and the release branches to run security checks.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

Recently in PRs, we've been getting warnings that our SAST tools don't have a known configuration for
some branches.  To fix this warning, we need to add push hooks for `master` and the release branches
to run security checks.

Signed-off-by: Andy Sadler <ansadler@redhat.com>
@service-binding-operator-bot service-binding-operator-bot added acceptance-tests-skipped Marks PR that does not need to run the acceptance tests approved cherry-pick kind/bug Something isn't working lgtm release/v1.4.x Used to mark PRs to be cherry-picked in release-v1.4.x branch labels Aug 22, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #1487 (c3d028f) into release-v1.4.x (64756b6) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-v1.4.x    #1487   +/-   ##
===============================================
  Coverage           58.16%   58.16%           
===============================================
  Files                  35       35           
  Lines                3014     3014           
===============================================
  Hits                 1753     1753           
  Misses               1093     1093           
  Partials              168      168           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64756b6...c3d028f. Read the comment docs.

@openshift-merge-robot openshift-merge-robot merged commit ec6e194 into redhat-developer:release-v1.4.x Aug 22, 2023
18 checks passed
@service-binding-operator-bot service-binding-operator-bot deleted the cherry-pick_release-v1.4.x_39908ed3_9ef14e34-4a66-4324-b99d-aad3e428d034 branch August 22, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acceptance-tests-skipped Marks PR that does not need to run the acceptance tests approved cherry-pick kind/bug Something isn't working lgtm release/v1.4.x Used to mark PRs to be cherry-picked in release-v1.4.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants