Deprecate relationship annotations #596
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test all |
isutton
force-pushed
the
annotations-removed
branch
from
20acc57
to
cb529f3
Compare
|
/test all |
|
/test all |
… and verify whether a value exists instead of its value
isutton
force-pushed
the
annotations-removed
branch
from
f7cf948
to
1137fa4
Compare
|
/retest |
|
/retest |
|
/retest |
1 similar comment
|
/retest |
Hmm.. To conclude, there are no side effects of not stamping annotations to SBR's related resource. There is only unidirectional tracing now. We can trace relationship from SBR to application but not from application to SBR. |
|
The changes seem good to be merged. Waiting for Igor to address this -> #596 (comment) |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DhritiShikhar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Not that I'm aware of... Perhaps the only one I can think of with is related to "nested" bindings, where for example a SBR might include a CR storing relevant data in a Secret: the current implementation won't match this Secret with a SBR but it can definitely be expanded to match resources related to the SBR at hand, in addition of checking whether the resource might appear as an application, service and intermediate/intermediary secret.
Yes, and to be more explicit: you do like you would with a database: filter the SBRs that have declared an arbitrary resource as either application, service and/or intermediate/intermediary secret. |
|
/test 4.5-e2e |
|
/test 4.5-acceptance |
|
/retest |
This PR deprecates the usage of annotations to relate Service Binding Requests and its services and applications in favor of a programmatic lookup.
Closes #458
Motivation
The main reason for this change is to reduce the amount of writes in the API server during the SBR reconciliation: those writes can trigger other reconciliation processes leading to unexpected race conditions; additionally, those annotations also seem to not be necessary to find a direct relationship between a Service Binding Request and a related resource, being it a service, application or the intermediate secret as changes in this PR can show.
Changes
This PR does not stamp the SBR information to related resources using annotations during the reconciliation process, and performs a lookup up to identify the SBR associated with an incoming change, if any.
Testing
Unit tests have been modified to a test table, and no e2e tests have been changed.