Remove SBR finalizers in the test namespace before deleting the namespace

[pmacik]

Motivation

Currently the acceptance tests setup deletes the test namespace and creates a new one. But if there are finalizers set on SBRs in that test namespace (for whatever reason) the deletion of the namespace is stuck in Terminating state.

Like in #476

Changes

This PR removes all the finalizers from all the SBRs in the test namespace just before it attempts the namespace deletion.

Testing

make e2e-cleanup

[pmacik]

/retest

[pmacik]

/retest

[Avni-Sharma]

Should #626 be considered in this regard? I think we should give that a look

[pmacik]

/test 4.5-unit

[pedjak]

deploy-clean make rule suffers from the same issue, because SBR CRD cannot be removed if SBR CRs contain finalizers.

[pedjak]

this PR tend to fix the issue that impacts local dev workflow. Hence, @DhritiShikhar @Avni-Sharma @akashshinde @baijum @isutton please test it locally. Right now, the following workflow is impacted and does not work on master:

1 start the operator with make local
2. follow up any of examples
3. stop the operator
4. try to start the operator with make local, the process does not move forward because SBR CRD cannot be removed

but it should work on this PR.

[Avni-Sharma]

Should #626 be considered in this regard? I think we should give that a look

cc @pedjak @pmacik

[DhritiShikhar]

I tried this PR locally.

➜  service-binding-operator git:(remove-finalizer) make test-acceptance VERBOSE=3
Requirement already up-to-date: setuptools in ./out/venv3/lib/python3.8/site-packages (50.0.0)
Requirement already up-to-date: pip in ./out/venv3/lib/python3.8/site-packages (20.2.2)
servicebindingrequest.apps.openshift.io/binding-request-1 patched
servicebindingrequest.apps.openshift.io/binding-request-2 patched
servicebindingrequest.apps.openshift.io/binding-request-a-d-s patched
servicebindingrequest.apps.openshift.io/binding-request-a-s-d patched
servicebindingrequest.apps.openshift.io/binding-request-d-a-s patched
servicebindingrequest.apps.openshift.io/binding-request-empty-app patched
servicebindingrequest.apps.openshift.io/binding-request-knative patched
servicebindingrequest.apps.openshift.io/binding-request-missing-app patched (no change)
namespace "test-namespace-6ec92571" deleted

SBR finalizers are removed.

[pedjak]

/retest

[pedjak]

#639 (review) is still not addressed

[pmacik]

I've rebased and squashed the commits.

[pedjak]

looks good - with an additional question

[pmacik]

/retest

[Avni-Sharma]

Should #626 be considered in this regard? I think we should give that a look

cc @pedjak @pmacik

Bumping my question up too...icymi :)

[pedjak]

/approve

@pmacik please squash the commits before we merge it.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pedjak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pedjak]

/lgtm