Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark e2e testsuite obsolete and disable it before removal. #659

Merged

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Sep 2, 2020

Motivation

This is the first step of removing the e2e test suite in favour of acceptance tests (https://issues.redhat.com/browse/APPSVC-648)

Changes

This PR disables the e2e tests by default unless ENABLE_OBSOLETE_E2E is set to true.
A warning like the following is shown instead:

$ make test-e2e
!WARNING: e2e tests are obsolete and will be removed soon in favour of acceptance tests,
!          so they are disabled by default. If you need to run it anyway, set ENABLE_OBSOLETE_E2E=true in the environment.
make: Nothing to be done for 'test-e2e'.

Testing

make test-e2e

@pmacik
Copy link
Contributor Author

pmacik commented Sep 2, 2020

/retest

@pedjak
Copy link
Contributor

pedjak commented Sep 2, 2020

/lgtm
/approve

Copy link
Contributor

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As CI shows, e2e-log-parser.sh file should be also made no-op.

@pedjak
Copy link
Contributor

pedjak commented Sep 2, 2020

/retest

@pedjak
Copy link
Contributor

pedjak commented Sep 3, 2020

/lgtm
/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b60b0c8 into redhat-developer:master Sep 3, 2020
@pmacik pmacik deleted the disable-obsolete-e2e branch November 27, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants