Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete e2e suite from repository #682

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

pmacik
Copy link
Contributor

@pmacik pmacik commented Sep 21, 2020

Motivation

Currently the obsolete e2e test suite is no longer used nor maintained. The acceptance tests replaced it.

Concludes APPSVC-648.

Changes

This PR:

  • Removes the e2e test suite from the codebase.
  • Renames formely e2e-related Makefile targets to a more general names.
  • Updates docs where e2e is mentioned with the acceptance tests instead.

Testing

@pmacik
Copy link
Contributor Author

pmacik commented Sep 21, 2020

/retest

1 similar comment
@pmacik
Copy link
Contributor Author

pmacik commented Sep 22, 2020

/retest

@pmacik
Copy link
Contributor Author

pmacik commented Sep 22, 2020

/test 4.5-acceptance

@pedjak
Copy link
Contributor

pedjak commented Sep 23, 2020

could we submit commit 007f033 as a separate PR? IMHO, it is not the related to the scope of this PR.

@pmacik
Copy link
Contributor Author

pmacik commented Sep 24, 2020

could we submit commit 007f033 as a separate PR? IMHO, it is not the related to the scope of this PR.

Ah, yes...

@pmacik
Copy link
Contributor Author

pmacik commented Sep 24, 2020

/test 4.5-acceptance

@pedjak
Copy link
Contributor

pedjak commented Sep 25, 2020

/lgtm
/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 235acf3 into redhat-developer:master Sep 25, 2020
isutton pushed a commit to isutton/service-binding-operator that referenced this pull request Sep 29, 2020
@pmacik pmacik deleted the remove-e2e branch November 27, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants