Update API group to binding.operators.coreos.com #865
Conversation
Codecov Report
@@ Coverage Diff @@
## master #865 +/- ##
=======================================
Coverage 61.19% 61.19%
=======================================
Files 26 26
Lines 1956 1956
=======================================
Hits 1197 1197
Misses 584 584
Partials 175 175
Continue to review full report at Codecov.
|
pedjak
force-pushed
the
update-api-group
branch
from
5fb9675
to
a349ef7
Compare
| layout: go.kubebuilder.io/v3 | ||
| projectName: service-binding-operator | ||
| repo: github.com/redhat-developer/service-binding-operator | ||
| resources: | ||
| - crdVersion: v1 | ||
| group: operators | ||
| group: binding |
There was a problem hiding this comment.
Previously the group name was plural operators, shouldn't the new group name be plural as well?
bindings instead of binding.
There was a problem hiding this comment.
The previous group name was set so that it matches the group used by OLM. Best practice is to keep group name as singular, because they are very much equivalent to package names:
The update is necessary and dictated by the fact that OLM does not allow deploying webhook for `operator.coreos.com` API group name: * https://docs.openshift.com/container-platform/4.6/operators/operator_sdk/osdk-generating-csvs.html#olm-webhook-considerations_osdk-generating-csvs * https://github.com/operator-framework/operator-lifecycle-manager/blob/master/pkg/controller/install/webhook.go#L29 Signed-off-by: Predrag Knezevic <pknezevi@redhat.com>
pedjak
force-pushed
the
update-api-group
branch
from
a349ef7
to
457a39d
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmacik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The update is necessary and dictated by the fact that OLM does not allow
deploying webhook for
operator.coreos.comAPI group name:Fixes #857