Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to enable automatic project configuration #122

Closed
fbricon opened this issue Dec 20, 2016 · 2 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#113
Closed

Allow users to enable automatic project configuration #122

fbricon opened this issue Dec 20, 2016 · 2 comments · Fixed by eclipse-jdtls/eclipse.jdt.ls#113
Assignees

Comments

@fbricon
Copy link
Collaborator

fbricon commented Dec 20, 2016

When modifying a pom.xml or a gradle file, java project configuration and classpath should be updated. While it's possible do trigger a manual update (ctrl+alt+u or cmd+alt+u), it'd be more convenient to do it automatically, as requested by @pmuir.

The proposed change is to display a warning when a build file has been modified, asking the user to update the java configuration. Choices are

  • Never: no project configuration will be triggered and the message won't show up again
  • Now: project configuration will be triggered and the message will show up next time
  • Always: project configuration will be triggered from now on and and the message won't show up again
@fbricon fbricon self-assigned this Dec 20, 2016
@fbricon fbricon added this to the Mid December 2016 milestone Dec 20, 2016
fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Dec 20, 2016
Required to fix redhat-developer/vscode-java#122

Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon added a commit to fbricon/vscode-java that referenced this issue Dec 20, 2016
Signed-off-by: Fred Bricon <fbricon@gmail.com>
@pmuir
Copy link
Contributor

pmuir commented Dec 20, 2016

@fbricon my other comment was that I wouldn't necessarily realise that "Update project configuration" would be what would cause the project classpath to update (unless I had used Eclipse).

fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Dec 21, 2016
Required to fix redhat-developer/vscode-java#122

Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Dec 21, 2016
Required to fix redhat-developer/vscode-java#122

Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon added a commit to eclipse-jdtls/eclipse.jdt.ls that referenced this issue Dec 21, 2016
Required to fix redhat-developer/vscode-java#122

Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon added a commit that referenced this issue Dec 21, 2016
Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon
Copy link
Collaborator Author

fbricon commented Dec 21, 2016

@pmuir that should be clearer, hopefully:
capture d ecran 2016-12-21 a 14 50 20

othomann pushed a commit to othomann/java-language-server that referenced this issue Dec 21, 2016
Required to fix redhat-developer/vscode-java#122

Signed-off-by: Fred Bricon <fbricon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants