Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent autocompletion behavior for constructors #143

Closed
fbricon opened this issue Jan 19, 2017 · 2 comments
Closed

Inconsistent autocompletion behavior for constructors #143

fbricon opened this issue Jan 19, 2017 · 2 comments
Assignees
@fbricon
Labels
bug content-assist upstream
Milestone
Mid February 2017

Comments

@fbricon
Copy link
Collaborator

fbricon commented Jan 19, 2017 •
edited

When triggering autocompletion on a constructor, when one continues typing, the selected/relevant proposal is lost, as some leading characters seem to be missing from the selection.

Additionally, in some circumstances, eg. after triggering autocomplete then deleting the previous character, the injected text is missing the leading characters (one or many).

See https://www.screencast.com/t/17vjLA8vC0hq
@fbricon
Copy link
Collaborator Author

fbricon commented Jan 19, 2017

@othomann do you a similar behavior in Orion? I wonder if this is a server or client problem (my guts say the latter)

@othomann
Copy link

No, I don't think I ever seen anything like this in Orion.

@fbricon fbricon mentioned this issue Feb 1, 2017
Closed
@fbricon fbricon changed the title Inconsistent autocompletion behavior Inconsistent autocompletion behavior for constructors Feb 2, 2017
fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Feb 2, 2017
@fbricon
Fix completions for constructors
6967672 
Merge proposal `()` and required proposal `constructor` in 1 text edit
Fixes redhat-developer/vscode-java#143

Requires eclipse-jdtls#129 to be applied.

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon mentioned this issue Feb 2, 2017
Merged
@fbricon fbricon self-assigned this Feb 2, 2017
@fbricon fbricon added this to the Late January 2017 milestone Feb 2, 2017
fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Feb 3, 2017
@fbricon
Fix completions for constructors
8e3de8a 
Merge proposal `()` and required proposal `constructor` in 1 text edit
Fixes redhat-developer/vscode-java#143

Requires eclipse-jdtls#129 to be applied.

Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Feb 3, 2017
@fbricon
Fix completions for constructors
6b192d5 
Merge proposal `()` and required proposal `constructor` in 1 text edit
Fixes redhat-developer/vscode-java#143

Requires eclipse-jdtls#129 to be applied.

Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Feb 3, 2017
@fbricon
Fix completions for constructors
ab2b477 
Merge proposal `()` and required proposal `constructor` in 1 text edit
Fixes redhat-developer/vscode-java#143

Requires eclipse-jdtls#129 to be applied.

Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Feb 3, 2017
@fbricon
Fix completions for constructors
c2a97bb 
Merge proposal `()` and required proposal `constructor` in 1 text edit
Fixes redhat-developer/vscode-java#143

Requires eclipse-jdtls#129 to be applied.

Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Feb 6, 2017
@fbricon
Fix completions for constructors
61db933 
Merge proposal `()` and required proposal `constructor` in 1 text edit
Fixes redhat-developer/vscode-java#143

Requires eclipse-jdtls#129 to be applied.

Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon added a commit to eclipse-jdtls/eclipse.jdt.ls that referenced this issue Feb 6, 2017
@fbricon
Fix completions for constructors
56f5629 
Merge proposal `()` and required proposal `constructor` in 1 text edit
Fixes redhat-developer/vscode-java#143

Requires #129 to be applied.

Signed-off-by: Fred Bricon <fbricon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbricon fbricon

Labels
bug content-assist upstream
Projects
None yet
Milestone
Mid February 2017
Development

No branches or pull requests
2 participants
@fbricon @othomann