Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java.projectConfiguration.update command to explorer menu, on build files #159

Closed
fbricon opened this issue Mar 1, 2017 · 7 comments
Assignees

Comments

@fbricon
Copy link
Collaborator

fbricon commented Mar 1, 2017

When right clicking on a pom.xml or gradle file, there should be a menu to run the Project Configuration Update command (java.projectConfiguration.update)

fbricon added a commit to fbricon/vscode-java that referenced this issue May 3, 2017
Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon self-assigned this May 3, 2017
@fbricon fbricon closed this as completed in ef178d2 May 3, 2017
@fbricon fbricon added this to the Late April 2017 milestone May 3, 2017
fbricon added a commit that referenced this issue May 3, 2017
When putting gradle files into a new gradle language id
syntax coloring is lost. Gradle files are already associated with the groovy language.

This reverts commit ef178d2.
@fbricon
Copy link
Collaborator Author

fbricon commented May 3, 2017

Turns out when putting Gradle files into a new gradle language id, syntax coloring is lost, as Gradle files are already associated with the Groovy language. So we definitely need a better way to match files

@fbricon fbricon reopened this May 3, 2017
@fbricon fbricon removed this from the Late April 2017 milestone May 3, 2017
@fbricon
Copy link
Collaborator Author

fbricon commented May 5, 2017

@jrieken @egamma any advice on how to better handle that one (as opposed to ef178d2)?

@egamma
Copy link

egamma commented May 5, 2017

@fbricon agreed, you should not introduce a new language Id for gradle otherwise you loose the coloring which is defined for the groovy language Id.

There is also a resourceFilename context , e.g.,"when": "resourceFilename == 'package.json'", but I assume you want to contribute the command to *.groovy, but wildcards are not supported for the resourceFilename context.

Another option is to optimistically contribute the command to the language Id for groovy
"when": "resourceLangId == groovy" and then check in the inside the command for the gradle suffix and inform the user that the command only applies to gradle files when it is not a gradle file. Obviously this is not perfect.

@jrieken
Copy link

jrieken commented May 5, 2017

Yeah, hard to get this right without making when-clauses support some sort of glob pattern matching

@fbricon
Copy link
Collaborator Author

fbricon commented May 5, 2017

@jrieken is there an issue already to get when clauses support glob pattern matching? Or I can open one :-)

@jrieken
Copy link

jrieken commented May 5, 2017

Go ahead - I was just searching for it but couldn't find anything... Should be pretty straight forward to implement.

@fbricon
Copy link
Collaborator Author

fbricon commented Jan 24, 2018

Issue fixed upstream, so now targeting the mid february release

fbricon added a commit to fbricon/vscode-java that referenced this issue Feb 5, 2018
…us, on build files

Requires vscode 1.20.

Fixes redhat-developer#159

Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon added a commit that referenced this issue Feb 7, 2018
…us, on build files

Requires vscode 1.20.

Fixes #159

Signed-off-by: Fred Bricon <fbricon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants