Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the project import status reports #179

Closed
gorkem opened this issue Apr 3, 2017 · 3 comments
Closed

Correct the project import status reports #179

gorkem opened this issue Apr 3, 2017 · 3 comments
Assignees
@fbricon
Labels
bug
Milestone
Mid April 2017

Comments

@gorkem
Copy link
Contributor

gorkem commented Apr 3, 2017

There is a difference between the reported status percentages and the actually change of the Starting Java Language Server message to started. I can observe it easily with Maven projects.
@gorkem gorkem added the bug label Apr 3, 2017
@fbricon
Copy link
Collaborator

fbricon commented Apr 10, 2017

Can you be more specific?

@gorkem
Copy link
Contributor Author

gorkem commented Apr 10, 2017

If you look at the traces, server sends language/status as 100% but it takes a long time after the actual server started is sent.

@fbricon
Copy link
Collaborator

fbricon commented Apr 10, 2017 •
edited

Apparently, this is caused by the monitor being set to 100% once the projects are imported, but then we're waiting for a workspace build to set the server status as started. See https://github.com/eclipse/eclipse.jdt.ls/blob/cfefb37728a3a50d3c530dd02ecefca489cfba17/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/InitHandler.java#L108

@fbricon fbricon mentioned this issue Apr 10, 2017
Merged
fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Apr 10, 2017
@fbricon
Include initial build progress monitor to compute overall readiness s…
a651b82 
…tatus

Fixes redhat-developer/vscode-java#179

Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon added a commit to eclipse-jdtls/eclipse.jdt.ls that referenced this issue Apr 11, 2017
@fbricon
Include initial build progress monitor to compute overall readiness s…
4a1e63d 
…tatus

Fixes redhat-developer/vscode-java#179

Signed-off-by: Fred Bricon <fbricon@gmail.com>
@fbricon fbricon added this to the Mid April 2017 milestone Apr 11, 2017
@fbricon fbricon self-assigned this Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbricon fbricon

Labels
bug
Projects
None yet
Milestone
Mid April 2017
Development

No branches or pull requests
2 participants
@gorkem @fbricon