Autocompletion is not cancelled on space

[fbricon]

If I have Collection c = ne| autocompletion will propose new among other things. If I continue typing without hitting tab or escape, then new Arr, despite the space, will continue proposing new and all other stuff containing these letters.

I think hitting space should cancel autocompletion. But I'm not sure if it's a vscode proper or vscode-java configuration. @jrieken?

[jrieken]

That is happens when proposals still match. VS Code doesn't have a static rule when to hide/show/retrigger completions but uses the information provided by completions. Those are the label (and filterText if present) and the range of the completion (which defaults to the current word). The existing text that is selected by the range is used to score against label (or filterText), in above sample new Arr against NewLineEvent - groovyjarjarantlr.debug.

ne| autocompletion will propose new among other things.

Is this just new or a full ctor-call, like new Collection? Or is 'among other things' other globals like NewLineEvent?

[fbricon]

I just keep on typing, no Ctrl+Space involved. So new is proposed, as well as other classes:

[fbricon]

Ok, so the fact the labels contain spaces is fucking us up

{
            "label": "NewInstanceInstantiator - org.springframework.objenesis.instantiator.basic",
            "kind": 7,
            "sortText": "zzzzzzzdhc",
            "data": {
                "decl_signature": "Lorg.springframework.objenesis.instantiator.basic.NewInstanceInstantiator;",
                "pid": "16",
                "rid": "29",
                "uri": "file:/Users/fbricon/Dev/projects/spring-boot-mongodb/src/main/java/guru/springframework/SpringBootMongodbApplication.java"
            }
        },
        {
            "label": "new",
            "kind": 14,
            "sortText": "zzzzzzzbej",
            "data": {
                "pid": "17",
                "rid": "29",
                "uri": "file:/Users/fbricon/Dev/projects/spring-boot-mongodb/src/main/java/guru/springframework/SpringBootMongodbApplication.java"
            }
        }

[jrieken]

Ok, so the fact the labels contain spaces is fucking us up

Yes, you could try putting that extra bit (org.springframework.objenesis.instantiator.basic et al) into detail

Works as I have to tried to describe above. What confuses me is that ArrayList is proposed towards the end of the gif. Are the completion lists you return marked as incomplete?

[fbricon]

Ok, I can try to put stuff into the detail field. Sounds better than my thinking about using some unicode trick to look like a space :-)

Seems we return "isIncomplete": false

[fbricon]

Ok so using detail seems to fix most of the problems when typing space. Changing all cases server-side to use detail is gonna be tedious, but doable. There would still be a minor problem with method completion though, because we display all overridden methods including parameters separated by space (We chose not to use SignatureHelp as we found it less productive), but I think that's manageable.

But the main problem with using detail is the proposal needs to be selected for the detail to be displayed. Currently, you can see all proposals with a Type - package pattern. We'd lose that package information.

[jrieken]

But the main problem with using detail is the proposal needs to be selected for the detail to be displayed. Currently, you can see all proposals with a Type - package pattern. We'd lose that package information.

Yeah, that's part of our design of being minimal. /cc @stevencl

[fbricon]

@jrieken so as an alternative, I tried using filterText:

/**
 * A string that should be used when filtering a set of
 * completion items. When `falsy` the label is used.
 */
filterText?: string;

So our completionItems now look like

{
  "label": "Map - java.util",
   "kind": 7,
   "sortText": "zzzzzzzbge",
   "filterText": "Map",
   "data": {
       "decl_signature": "Ljava.util.Map;",
       "pid": "62",
       "rid": "6",
       "uri": "file:/Users/fbricon/Dev/vertx-game-server/src/main/java/com/redhat/middleware/keynote/GameUtils.java"
     }
},

But vscode still seems to filter using the label

So either I don't grok how filterText is supposed to work or vscode ignores filterText. The former is the most plausible.

[jrieken]

But vscode still seems to filter using the label

Yeah, we always try with the label first and use the filter text only when not matching the label. Mostly because when using the filter text we cannot render the blue highlights. But it could be considered a bug on our side

[fbricon]

Initial tests with filterText and latest insiders build look good. Will provide a proper PR on jdt.ls soon.