-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syntax server no longer exits once JDT server is initialized #1928
Comments
Looks to be an upstream issue microsoft/vscode-languageserver-node#723 . |
rgrunber
added a commit
to rgrunber/vscode-java
that referenced
this issue
Jun 2, 2021
- Fixes redhat-developer#1928 - In languageclient 7.x, the client fails to send the necessary exit() once a shutdown() response is received from the language server - When client defines syntaxServerExitsOnShutdown as true, the language server will exit immediately after the shutdown request Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber
added a commit
that referenced
this issue
Jun 3, 2021
- Fixes #1928 - In languageclient 7.x, the client fails to send the necessary exit() once a shutdown() response is received from the language server - When client defines syntaxServerExitsOnShutdown as true, the language server will exit immediately after the shutdown request Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
As soon as the upstream issue is resolved (scheduled for 3.16.1?) we can remove this option. This should work around the issue until then. We're basically calling exit() as part of shutdown() if the client sets this property. I've tested this in lightweight and hybrid modes, and it seems to behave correctly. |
rgrunber
added a commit
to rgrunber/vscode-java
that referenced
this issue
Jun 28, 2021
- syntaxServerExitsOnShutdown -> shouldLanguageServerExitOnShutdown - Standard language server should also exit on shutdown - Related redhat-developer#1928 Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber
added a commit
that referenced
this issue
Jun 28, 2021
- syntaxServerExitsOnShutdown -> shouldLanguageServerExitOnShutdown - Standard language server should also exit on shutdown - Related #1928 Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using vscode-java 0.79.0 or newer, and running
watch -n1 -d 'jps -l | grep -v jps'
in some terminal, I noticed that the syntax server no longer exits once the language server has completed its startup.Environment
Linux (Fedora 33)
VS Code 1.55.2
This seems to have started happening with #1894 ( 9f32875 ) , but I don't think we do anything with the exit logic. Is there a chance this is a bug in that library ?
Instead, all I see is the following show up in the errors :
Debugging this I see it happens for the following data :
'Content-Length: 33\r\n\r\n'
{"jsonrpc":"2.0","method":"exit"}
The text was updated successfully, but these errors were encountered: